- Isis-fish-commits - mailman.cloud.codelutin.com

r3631 - in trunk/src/main/java/fr/ifremer/isisfish/ui: models/common result sensitivity simulator widget
by echatellier＠users.forge.codelutin.com March 5, 2012

March 5, 2012

Author: echatellier Date: 2012-03-05 11:23:44 +0100 (Mon, 05 Mar 2012) New Revision: 3631 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3631 Log: Fix monitoring performance problems Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/models/common/StringComboModel.java trunk/src/main/java/fr/ifremer/isisfish/ui/result/ResultHandler.java trunk/src/main/java/fr/ifremer/isisfish/ui/sensitivity/SensitivitySecondPassUI.jaxx trunk/src/main/java/fr/ifremer/isisfish/ui/simulator/ParamsUI.jaxx trunk/src/main/java/fr/ifremer/isisfish/ui/widget/FilterableComboBox.java Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/models/common/StringComboModel.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/ui/models/common/StringComboModel.java 2012-03-02 15:20:56 UTC (rev 3630) +++ trunk/src/main/java/fr/ifremer/isisfish/ui/models/common/StringComboModel.java 2012-03-05 10:23:44 UTC (rev 3631) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2011 Ifremer, CodeLutin, Chatellier Eric + * Copyright (C) 2011 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -25,6 +25,7 @@ package fr.ifremer.isisfish.ui.models.common; +import java.util.ArrayList; import java.util.List; import javax.swing.DefaultComboBoxModel; @@ -79,11 +80,20 @@ * @param stringList {@link String} list to set */ public void setStringList(List<String> stringList) { - this.stringList = stringList; + this.stringList = new ArrayList<String>(stringList); // reset selected setSelectedItem(null); } + public void addString(String string) { + stringList.add(string); + fireIntervalAdded(this, stringList.size() - 1, stringList.size()); + } + + public boolean containsString(String string) { + return stringList.contains(string); + } + /* * @see javax.swing.ListModel#getElementAt(int) */ Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/result/ResultHandler.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/ui/result/ResultHandler.java 2012-03-02 15:20:56 UTC (rev 3630) +++ trunk/src/main/java/fr/ifremer/isisfish/ui/result/ResultHandler.java 2012-03-05 10:23:44 UTC (rev 3631) @@ -92,7 +92,8 @@ } @Override public void simulationStop(SimulationService simService, SimulationJob job) { - initSimulationList(resultUI); + StringComboModel model = (StringComboModel)resultUI.getSimulationComboBox().getModel(); + model.addString(job.getId()); } @Override public void clearJobDone(SimulationService simService) { Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/sensitivity/SensitivitySecondPassUI.jaxx =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/ui/sensitivity/SensitivitySecondPassUI.jaxx 2012-03-02 15:20:56 UTC (rev 3630) +++ trunk/src/main/java/fr/ifremer/isisfish/ui/sensitivity/SensitivitySecondPassUI.jaxx 2012-03-05 10:23:44 UTC (rev 3631) @@ -54,7 +54,14 @@ if (log.isDebugEnabled()) { log.debug("Refresh second pass UI simulations list"); } - fieldSensitivitySimulationSelect.setModel(getSensitivitySimulationModel()); + StringComboModel model = (StringComboModel)fieldSensitivitySimulationSelect.getModel(); + String simulationName = job.getId(); + if (simulationName.startsWith("as_")) { + String masterSensitivityName = simulationName.substring(0, simulationName.lastIndexOf("_")); + if (!model.containsString(masterSensitivityName)) { + model.addString(masterSensitivityName); + } + } } @Override @@ -68,7 +75,7 @@ * Model de contenu de la liste des nom de simulations */ public StringComboModel getSensitivitySimulationModel() { - java.util.List<String> asNames = new ArrayList<String>(); + List<String> asNames = new ArrayList<String>(); for (String simulationName : SimulationStorage.getSimulationNames()) { if (simulationName.startsWith("as_")) { String masterSensitivityName = simulationName.substring(0, simulationName.lastIndexOf("_")); Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/simulator/ParamsUI.jaxx =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/ui/simulator/ParamsUI.jaxx 2012-03-02 15:20:56 UTC (rev 3630) +++ trunk/src/main/java/fr/ifremer/isisfish/ui/simulator/ParamsUI.jaxx 2012-03-05 10:23:44 UTC (rev 3631) @@ -5,7 +5,7 @@ $Id$ $HeadURL$ %% - Copyright (C) 2005 - 2011 Ifremer, CodeLutin, Chatellier Eric + Copyright (C) 2005 - 2012 Ifremer, CodeLutin, Chatellier Eric %% This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as @@ -93,7 +93,8 @@ @Override public void simulationStop(SimulationService simService, SimulationJob job) { - fieldSimulParamsSelect.setModel(getSimulParamsSelectModel(true)); + StringComboModel model = (StringComboModel)fieldSimulParamsSelect.getModel(); + model.addString(job.getId()); } @Override @@ -306,13 +307,8 @@ } protected ComboBoxModel getSimulParamsSelectModel(boolean force) { - java.util.List<String> items = simulAction.getFilteredOldSimulatorNames(force); - DefaultComboBoxModel result = new DefaultComboBoxModel(); - if (items != null) { - for (String s : items){ - result.addElement(s); - } - } + List<String> items = simulAction.getFilteredOldSimulatorNames(force); + StringComboModel result = new StringComboModel(items); return result; } Modified: trunk/src/main/java/fr/ifremer/isisfish/ui/widget/FilterableComboBox.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/ui/widget/FilterableComboBox.java 2012-03-02 15:20:56 UTC (rev 3630) +++ trunk/src/main/java/fr/ifremer/isisfish/ui/widget/FilterableComboBox.java 2012-03-05 10:23:44 UTC (rev 3631) @@ -3,7 +3,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2011 Codelutin, Chatellier Eric + * Copyright (C) 2012 Ifremer, Codelutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -32,16 +32,19 @@ import java.util.ArrayList; import java.util.List; +import javax.swing.AbstractListModel; import javax.swing.ComboBoxModel; -import javax.swing.DefaultComboBoxModel; import javax.swing.JButton; import javax.swing.JComboBox; import javax.swing.JPanel; import javax.swing.JTextField; import javax.swing.event.DocumentEvent; import javax.swing.event.DocumentListener; +import javax.swing.event.ListDataEvent; +import javax.swing.event.ListDataListener; -import org.jdesktop.swingx.JXComboBox; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.jdesktop.swingx.JXTextField; import org.nuiton.util.Resource; @@ -54,8 +57,10 @@ * Last update : $Date$ * By : $Author$ */ -public class FilterableComboBox extends JPanel { +public class FilterableComboBox extends JPanel implements ListDataListener { + private static Log log = LogFactory.getLog(FilterableComboBox.class); + /** serialVersionUID. */ private static final long serialVersionUID = -6669320998140538372L; @@ -69,13 +74,6 @@ protected boolean filtering = false; - /* - * Il faut obligatoirement que la liste filtrées soit mise en cache, car - * l'appeler dans le getElementAt() comme c'était fait avant dégrade énormement - * les perfs, un truc de dingue. - */ - protected List<Object> itemCache; - public FilterableComboBox() { actionListeners = new ArrayList<ActionListener>(); buildLayout(); @@ -86,58 +84,77 @@ setModel(model); } - class FilterComboBoxModel extends DefaultComboBoxModel { + class FilterComboBoxModel extends AbstractListModel implements ComboBoxModel { /** serialVersionUID. */ private static final long serialVersionUID = 6256289874593024153L; protected ComboBoxModel model; + protected List<Integer> realIndexes = new ArrayList<Integer>(); + + protected Object selectedItem; + public FilterComboBoxModel(ComboBoxModel model) { this.model = model; + fireDataChanged(); } + public ComboBoxModel getModel() { + return model; + } + @Override public int getSize() { - int size = 0; - if (itemCache != null) { - size = itemCache.size(); - } else { - size = model.getSize(); - } + int size = realIndexes.size(); return size; } @Override public Object getElementAt(int index) { - Object element = null; - if (itemCache != null) { - element = itemCache.get(index); - } else { - element = model.getElementAt(index); - } + int realIndex = realIndexes.get(index); + Object element = model.getElementAt(realIndex); return element; } public void fireDataChanged() { filtering = true; - super.fireContentsChanged(this, 0, model.getSize()); - + + if (log.isDebugEnabled()) { + log.debug("Refreshing real indexes list"); + log.debug("model.getSize() = " + model.getSize()); + log.debug("model.getSize() = " + model.getSize()); + } + // filter list - int delegateSize = model.getSize(); - itemCache = new ArrayList<Object>(delegateSize); - for (int i = 0; i < delegateSize; ++i) { + realIndexes.clear(); + for (int i = 0; i < model.getSize(); ++i) { Object element = model.getElementAt(i); - if (element.toString().matches(".*" + filterField.getText() + ".*")) { - itemCache.add(element); + if (element.toString().contains(filterField.getText())) { + realIndexes.add(i); } } + + if (log.isDebugEnabled()) { + log.debug("realIndexes.size() = " + realIndexes.size()); + } + + fireIntervalRemoved(this, 0, model.getSize()); + fireIntervalAdded(this, 0, realIndexes.size()); filtering = false; } - - + + @Override + public void setSelectedItem(Object anItem) { + this.selectedItem = anItem; + } + + @Override + public Object getSelectedItem() { + return selectedItem; + } } - + class FilterDocumentListener implements DocumentListener { @Override public void insertUpdate(DocumentEvent e) { @@ -153,9 +170,9 @@ public void changedUpdate(DocumentEvent e) { updateFilter(); } - + protected void updateFilter() { - ((FilterComboBoxModel)dataBox.getModel()).fireDataChanged(); + ((FilterComboBoxModel) dataBox.getModel()).fireDataChanged(); resetButton.setEnabled(!filterField.getText().isEmpty()); } } @@ -188,7 +205,7 @@ * Build layout. */ private void buildLayout() { - dataBox = new JXComboBox(); + dataBox = new JComboBox(); dataBox.addActionListener(new ComboBoxActionListener()); filterField = new JXTextField(_("isisfish.common.filter")); // fix size @@ -214,13 +231,18 @@ * @param model model to set */ public void setModel(ComboBoxModel model) { + model.addListDataListener(this); dataBox.setModel(new FilterComboBoxModel(model)); } + public ComboBoxModel getModel() { + return ((FilterComboBoxModel)dataBox.getModel()).getModel(); + } + public Object getSelectedItem() { return dataBox.getSelectedItem(); } - + public void setSelectedItem(Object object) { dataBox.setSelectedItem(object); } @@ -232,4 +254,43 @@ public boolean removeActionListener(ActionListener o) { return actionListeners.remove(o); } + + /* + * @see javax.swing.event.ListDataListener#intervalAdded(javax.swing.event.ListDataEvent) + */ + @Override + public void intervalAdded(ListDataEvent e) { + if (!filtering) { + if (log.isDebugEnabled()) { + log.debug("intervalAdded : fireDataChanged"); + } + ((FilterComboBoxModel) dataBox.getModel()).fireDataChanged(); + } + } + + /* + * @see javax.swing.event.ListDataListener#intervalRemoved(javax.swing.event.ListDataEvent) + */ + @Override + public void intervalRemoved(ListDataEvent e) { + if (!filtering) { + if (log.isDebugEnabled()) { + log.debug("intervalRemoved : fireDataChanged"); + } + ((FilterComboBoxModel) dataBox.getModel()).fireDataChanged(); + } + } + + /* + * @see javax.swing.event.ListDataListener#contentsChanged(javax.swing.event.ListDataEvent) + */ + @Override + public void contentsChanged(ListDataEvent e) { + if (!filtering) { + if (log.isDebugEnabled()) { + log.debug("contentsChanged : fireDataChanged"); + } + ((FilterComboBoxModel) dataBox.getModel()).fireDataChanged(); + } + } }

1 0

r3630 - trunk/src/test/java/fr/ifremer/isisfish/util
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 16:20:56 +0100 (Fri, 02 Mar 2012) New Revision: 3630 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3630 Log: Fix tests since official/community lookup refactoring. Refactor test official/community configuration. Modified: trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java Modified: trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java 2012-03-02 15:20:25 UTC (rev 3629) +++ trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java 2012-03-02 15:20:56 UTC (rev 3630) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, Code Lutin + * Copyright (C) 2009 - 2012 Ifremer, Code Lutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -29,8 +29,6 @@ import java.io.IOException; import java.io.PrintWriter; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.junit.Assert; import org.junit.Test; @@ -52,9 +50,6 @@ */ public class JavadocHelperTest extends AbstractIsisFishTest { - /** Class logger */ - private static Log log = LogFactory.getLog(JavadocHelperTest.class); - /** * Try to generate javadoc on current isis-fish-data directory. * (single java file case)

1 0

r3629 - trunk/src/test/java/fr/ifremer/isisfish/util
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 16:20:25 +0100 (Fri, 02 Mar 2012) New Revision: 3629 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3629 Log: Fix tests since official/community lookup refactoring. Refactor test official/community configuration. Modified: trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java Modified: trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java 2012-03-02 14:59:13 UTC (rev 3628) +++ trunk/src/test/java/fr/ifremer/isisfish/util/JavadocHelperTest.java 2012-03-02 15:20:25 UTC (rev 3629) @@ -35,6 +35,7 @@ import org.junit.Test; import fr.ifremer.isisfish.AbstractIsisFishTest; +import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.datastore.SimulationPlanStorage; /** @@ -64,7 +65,7 @@ @Test public void testIsisFishDataJavadoc() throws IOException, ClassNotFoundException { - File currentDirectory = getCurrentDatabaseDirectory(); + File currentDirectory = IsisFish.config.getDatabaseDirectory(); File destinationDirectory = new File(getTestDirectory(), "isis-docs"); File testJavaFile = new File(currentDirectory, SimulationPlanStorage.SIMULATION_PLAN_PATH + File.separatorChar + "CalibrationSimplexePasVariable2Capturabilite.java");

1 0

r3628 - trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 15:59:13 +0100 (Fri, 02 Mar 2012) New Revision: 3628 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3628 Log: Perf : don't test remote existence on simulation start Modified: trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/InProcessSimulatorLauncher.java Modified: trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/InProcessSimulatorLauncher.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/InProcessSimulatorLauncher.java 2012-03-02 13:08:28 UTC (rev 3627) +++ trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/InProcessSimulatorLauncher.java 2012-03-02 14:59:13 UTC (rev 3628) @@ -105,7 +105,7 @@ try { // remove simulation if already exists - if (SimulationStorage.exists(id)) { + if (SimulationStorage.localyExists(id)) { if (log.isWarnEnabled()) { log.warn("Warning , simulation " + id + " aleady exists"); log.warn("Deleting it before doing simulation");

1 0

r3627 - in trunk/src: main/java/fr/ifremer/isisfish/datastore main/java/fr/ifremer/isisfish/simulator main/java/fr/ifremer/isisfish/util test/java/fr/ifremer/isisfish test/java/fr/ifremer/isisfish/datastore test/java/fr/ifremer/isisfish/util
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 14:08:28 +0100 (Fri, 02 Mar 2012) New Revision: 3627 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3627 Log: Fix tests since official/community lookup refactoring. Refactor test official/community configuration. Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/CodeSourceStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/ExportStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/RuleStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/ScriptStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityExportStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulationPlanStorage.java trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulatorStorage.java trunk/src/main/java/fr/ifremer/isisfish/simulator/SimulationParameterImpl.java trunk/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java trunk/src/test/java/fr/ifremer/isisfish/AbstractIsisFishTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/ExportStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/RuleStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/ScriptStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityExportStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulationPlanStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulatorStorageTest.java trunk/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/CodeSourceStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/CodeSourceStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/CodeSourceStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -77,6 +77,10 @@ return directory; } + public void setDirectory(File... directory) { + this.directory = directory; + } + /* * @see java.lang.Iterable#iterator() */ Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/ExportStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/ExportStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/ExportStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -37,7 +37,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.export.Export; import fr.ifremer.isisfish.util.Doc; import fr.ifremer.isisfish.util.Docable; Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/RuleStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/RuleStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/RuleStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -37,7 +37,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.rule.Rule; import fr.ifremer.isisfish.util.Doc; import fr.ifremer.isisfish.util.Docable; @@ -133,7 +132,8 @@ Location loc = locs[i]; for (File dir : loc.getDirectories()) { RuleStorage storage = new RuleStorage(dir, new File(dir, RULE_PATH), name); - if (storage.getFile().isFile()) { + File sFile = storage.getFile(); + if (sFile.isFile()) { result = storage; rulesCache.put(name, result); } Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/ScriptStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/ScriptStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/ScriptStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -33,7 +33,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.vcs.VCSException; /** Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -37,7 +37,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.simulator.sensitivity.SensitivityAnalysis; import fr.ifremer.isisfish.util.Doc; import fr.ifremer.isisfish.util.Docable; Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityExportStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityExportStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/SensitivityExportStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -33,7 +33,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.export.SensitivityExport; import fr.ifremer.isisfish.util.Docable; import fr.ifremer.isisfish.vcs.VCSException; Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulationPlanStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulationPlanStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulationPlanStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -37,7 +37,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.simulator.SimulationPlan; import fr.ifremer.isisfish.util.Doc; import fr.ifremer.isisfish.util.Docable; Modified: trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulatorStorage.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulatorStorage.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/datastore/SimulatorStorage.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -33,7 +33,6 @@ import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; -import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.simulator.Simulator; import fr.ifremer.isisfish.vcs.VCSException; Modified: trunk/src/main/java/fr/ifremer/isisfish/simulator/SimulationParameterImpl.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/simulator/SimulationParameterImpl.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/simulator/SimulationParameterImpl.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -488,12 +488,13 @@ for (String name : planList) { if (name != null && !"".equals(name)) { try { - SimulationPlan plan = SimulationPlanStorage - .getSimulationPlan(name) - .getNewSimulationPlanInstance(); - StorageHelper.populateStorageParams(planIndex++, - getRegion().getStorage(), plan, propertiesParameters, "plan"); - simulationPlans.add(plan); + SimulationPlanStorage planStorage = SimulationPlanStorage.getSimulationPlan(name); + if (planStorage != null) { // since 4.0.0.3 can return null + SimulationPlan plan = planStorage.getNewSimulationPlanInstance(); + StorageHelper.populateStorageParams(planIndex++, + getRegion().getStorage(), plan, propertiesParameters, "plan"); + simulationPlans.add(plan); + } } catch (IsisFishException eee) { if (log.isWarnEnabled()) { log.warn("Can't find plan: " + name, eee); Modified: trunk/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -191,6 +191,13 @@ classpath.add(rootSrc.getAbsoluteFile()); + // works better than + // fileManager.setLocation(StandardLocation.SOURCE_PATH, Location.ALL); + // for some test + for (File dir : Location.ALL.getDirectories()) { + classpath.add(dir); + } + result = compile(classpath, src, dest, out); } catch (Exception eee) { if (log.isWarnEnabled()) { @@ -223,7 +230,6 @@ // JavaCompiler compiler = ToolProvider.getSystemJavaCompiler(); StandardJavaFileManager fileManager = compiler .getStandardFileManager(null, null, null); - fileManager.setLocation(StandardLocation.SOURCE_PATH, Location.ALL); Iterable<? extends JavaFileObject> compilationUnits = fileManager .getJavaFileObjectsFromFiles(src); Modified: trunk/src/test/java/fr/ifremer/isisfish/AbstractIsisFishTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/AbstractIsisFishTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/AbstractIsisFishTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -36,6 +36,7 @@ import org.nuiton.util.FileUtil; import fr.ifremer.isisfish.datastore.AutoMigrationIsisH2Config; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.cache.ClassTemplateLoader; import freemarker.ext.beans.BeansWrapper; import freemarker.template.Configuration; @@ -56,7 +57,7 @@ */ public abstract class AbstractIsisFishTest { - protected static File dirDatabase; + protected static File dirIsisBase; /** * Return specific temp dir. @@ -86,12 +87,12 @@ public static void init() throws Exception { File mavenTestDir = getTestDirectory(); - dirDatabase = FileUtil.createTempDirectory("isisdbtest", "", mavenTestDir); + dirIsisBase = FileUtil.createTempDirectory("isisdbtest", "", mavenTestDir); - System.setProperty("user.home", dirDatabase.getAbsolutePath()); + System.setProperty("user.home", dirIsisBase.getAbsolutePath()); System.setProperty(IsisConfig.Option.LAUNCH_UI.key, "false"); - System.setProperty(IsisConfig.Option.DATABASE_DIRECTORY.key, dirDatabase.getAbsolutePath()); - System.setProperty(IsisConfig.Option.SSH_KEY_FILE.key, dirDatabase.getAbsolutePath() + File.separator + "ssh" + File.separator + "isis_test_dsa"); + System.setProperty(IsisConfig.Option.ISIS_HOME_DIRECTORY.key, dirIsisBase.getAbsolutePath()); + System.setProperty(IsisConfig.Option.SSH_KEY_FILE.key, dirIsisBase.getAbsolutePath() + File.separator + "ssh" + File.separator + "isis_test_dsa"); IsisFish.init(); IsisFish.initVCS(); @@ -101,7 +102,7 @@ AutoMigrationIsisH2Config.setTestMigrationCallBack(); FileUtils.copyDirectory(new File("src/test/resources/test-database"), - dirDatabase, new FileFilter() { + IsisFish.config.getDatabaseDirectory(), new FileFilter() { @Override public boolean accept(File pathname) { boolean result = true; @@ -122,6 +123,11 @@ public void resetConfig() throws ArgumentsParserException { IsisFish.config = new IsisConfig(); IsisFish.config.parse(); + + // fix static cache in enum + Location.OFFICIAL.setDirectory(IsisFish.config.getDatabaseDirectory()); + Location.COMMUNITY.setDirectory(IsisFish.config.getCommunityDatabaseDirectory()); + Location.ALL.setDirectory(IsisFish.config.getDatabaseDirectory(), IsisFish.config.getCommunityDatabaseDirectory()); } /** @@ -130,7 +136,7 @@ * @return current database directory */ protected static File getCurrentDatabaseDirectory() { - return dirDatabase; + return dirIsisBase; } /** @@ -139,9 +145,9 @@ @AfterClass public static void clean() { System.clearProperty("user.home"); - if (dirDatabase != null) { - FileUtil.deleteRecursively(dirDatabase); - dirDatabase = null; + if (dirIsisBase != null) { + FileUtil.deleteRecursively(dirIsisBase); + dirIsisBase = null; } } Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/ExportStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/ExportStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/ExportStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -37,6 +37,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -65,7 +66,7 @@ String fileName = "TestExport1"; - ExportStorage exportStorage = ExportStorage.getExport(fileName); + ExportStorage exportStorage = ExportStorage.createExport(fileName, Location.COMMUNITY); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/RuleStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/RuleStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/RuleStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -37,6 +37,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -65,7 +66,7 @@ String fileName = "TestRule1"; - RuleStorage ruleStorage = RuleStorage.getRule(fileName); + RuleStorage ruleStorage = RuleStorage.createRule(fileName, Location.OFFICIAL); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/ScriptStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/ScriptStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/ScriptStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -38,6 +38,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -69,10 +70,10 @@ String content1 = "public class test { public static void main(String[]args) {System.out.println(\"The test 1 :)\")} "; String content2 = "public class test { public static void main(String[]args) {System.out.println(\"The test 2 :) with different length :(\")} "; - ScriptStorage script = ScriptStorage.getScript("test"); + ScriptStorage script = ScriptStorage.createScript("test", Location.COMMUNITY); try { - System.out.println("File: " + script.getFile()); - System.out.println("Content: '" + script.getContent() + "'"); + //System.out.println("File: " + script.getFile()); + //System.out.println("Content: '" + script.getContent() + "'"); Assert.assertFalse(script.exists()); Assert.assertEquals("", script.getContent()); @@ -80,11 +81,11 @@ script.setContent(content1); Assert.assertTrue(script.exists()); - System.out.println("Content: '" + script.getContent() + "'"); + //System.out.println("Content: '" + script.getContent() + "'"); Assert.assertEquals(content1, script.getContent()); FileUtil.writeString(script.getFile(), content2); - System.out.println("Content: '" + script.getContent() + "'"); + //System.out.println("Content: '" + script.getContent() + "'"); Assert.assertEquals(content2, script.getContent()); } finally { script.delete(false); @@ -97,7 +98,7 @@ String fileName = "TestScript1"; - ScriptStorage scriptStorage = ScriptStorage.getScript(fileName); + ScriptStorage scriptStorage = ScriptStorage.createScript(fileName, Location.COMMUNITY); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityAnalysisStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -37,6 +37,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -66,7 +67,7 @@ String fileName = "TestSensitivityAnalysis1"; SensitivityAnalysisStorage sensitivityStorage = SensitivityAnalysisStorage - .getSensitivityAnalysis(fileName); + .createSensitivityAnalysis(fileName, Location.OFFICIAL); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityExportStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityExportStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/SensitivityExportStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -37,6 +37,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -65,7 +66,7 @@ String fileName = "TestSensitivityExport1"; - SensitivityExportStorage sensitivityExportStorage = SensitivityExportStorage.getSensitivityExport(fileName); + SensitivityExportStorage sensitivityExportStorage = SensitivityExportStorage.createSensitivityExport(fileName, Location.COMMUNITY); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulationPlanStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulationPlanStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulationPlanStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2011 Ifremer, CodeLutin, Chatellier Eric + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -37,6 +37,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import freemarker.template.Configuration; import freemarker.template.Template; @@ -66,7 +67,7 @@ String fileName = "TestSimulationPlan1"; SimulationPlanStorage simulationPlanStorage = SimulationPlanStorage - .getSimulationPlan(fileName); + .createSimulationPlan(fileName, Location.OFFICIAL); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulatorStorageTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulatorStorageTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/datastore/SimulatorStorageTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2009 - 2010 Ifremer, CodeLutin + * Copyright (C) 2009 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -41,6 +41,7 @@ import fr.ifremer.isisfish.AbstractIsisFishTest; import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishException; +import fr.ifremer.isisfish.datastore.CodeSourceStorage.Location; import fr.ifremer.isisfish.simulator.Simulator; import freemarker.template.Configuration; import freemarker.template.Template; @@ -73,7 +74,7 @@ String fileName = "TestSimulator1"; SimulatorStorage simulatorStorage = SimulatorStorage - .getSimulator(fileName); + .createSimulator(fileName, Location.COMMUNITY); // get template Template template = freemarkerConfiguration Modified: trunk/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java =================================================================== --- trunk/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java 2012-03-02 11:08:10 UTC (rev 3626) +++ trunk/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java 2012-03-02 13:08:28 UTC (rev 3627) @@ -152,8 +152,8 @@ List<File> classpath = new ArrayList<File>(); classpath.add(fB.getParentFile()); - CompileHelper.compile(classpath, Collections.singletonList(fB), dest, - null); + int result = CompileHelper.compile(classpath, Collections.singletonList(fB), dest, null); + Assert.assertEquals(0, result); // essai de chargement de la classe URL[] cp = new URL[] { dest.toURI().toURL() };

1 0

r3626 - branches/4.1
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 12:08:10 +0100 (Fri, 02 Mar 2012) New Revision: 3626 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3626 Log: #914 : Update to freemarker 2.3.19 Modified: branches/4.1/pom.xml Modified: branches/4.1/pom.xml =================================================================== --- branches/4.1/pom.xml 2012-03-02 10:37:40 UTC (rev 3625) +++ branches/4.1/pom.xml 2012-03-02 11:08:10 UTC (rev 3626) @@ -385,7 +385,7 @@ <dependency> <groupId>org.freemarker</groupId> <artifactId>freemarker</artifactId> - <version>2.3.18</version> + <version>2.3.19</version> <scope>compile</scope> </dependency>

1 0

r3625 - trunk/src/main/java/fr/ifremer/isisfish
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 11:37:40 +0100 (Fri, 02 Mar 2012) New Revision: 3625 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3625 Log: Don't check for file collision in simulations directory (huge time to check) Modified: trunk/src/main/java/fr/ifremer/isisfish/IsisFish.java Modified: trunk/src/main/java/fr/ifremer/isisfish/IsisFish.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/IsisFish.java 2012-03-02 10:11:22 UTC (rev 3624) +++ trunk/src/main/java/fr/ifremer/isisfish/IsisFish.java 2012-03-02 10:37:40 UTC (rev 3625) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2005 - 2011 Ifremer, CodeLutin, Chatellier Eric + * Copyright (C) 2005 - 2012 Ifremer, CodeLutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -33,10 +33,10 @@ import java.awt.event.WindowAdapter; import java.awt.event.WindowEvent; import java.io.File; -import java.io.FileFilter; import java.io.IOException; import java.io.InputStream; import java.text.SimpleDateFormat; +import java.util.Collection; import java.util.List; import javax.imageio.ImageIO; @@ -47,6 +47,8 @@ import javax.swing.UIManager; import javax.swing.UnsupportedLookAndFeelException; +import org.apache.commons.io.FileUtils; +import org.apache.commons.io.filefilter.AbstractFileFilter; import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -538,13 +540,23 @@ */ protected static void checkDuplicatedFiles() { + long before = System.currentTimeMillis(); + // get official file list - List<File> offFiles = FileUtil.getFilteredElements(IsisFish.config.getDatabaseDirectory(), new FileFilter() { - @Override - public boolean accept(File pathname) { - return pathname.getName().endsWith(".java"); - } - }, true); + Collection<File> offFiles = FileUtils.listFiles(IsisFish.config.getDatabaseDirectory(), + new AbstractFileFilter() { + @Override + public boolean accept(File dir, String name) { + return name.endsWith(".java"); + } + }, + new AbstractFileFilter() { + @Override + public boolean accept(File dir, String name) { + // exclude simulations directory (can take huge time) + return !name.equals(SimulationStorage.SIMULATION_PATH); + } + }); // compare it with community repo for (File offFile : offFiles) { @@ -558,6 +570,11 @@ comFile.renameTo(newFile); } } + + if (log.isDebugEnabled()) { + long after = System.currentTimeMillis(); + log.debug("Check corrumpted file in " + (after - before) + " ms"); + } } /**

1 0

r3624 - trunk/src/main/java/fr/ifremer/isisfish
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 11:11:22 +0100 (Fri, 02 Mar 2012) New Revision: 3624 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3624 Log: Fix caparmor default database directory Modified: trunk/src/main/java/fr/ifremer/isisfish/IsisConfig.java Modified: trunk/src/main/java/fr/ifremer/isisfish/IsisConfig.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/IsisConfig.java 2012-03-02 09:51:52 UTC (rev 3623) +++ trunk/src/main/java/fr/ifremer/isisfish/IsisConfig.java 2012-03-02 10:11:22 UTC (rev 3624) @@ -918,7 +918,7 @@ /** Serveur accessible par ssh : user home directory */ SIMULATOR_SSH_USER_HOME("simulation.ssh.userhome", n_("isisfish.config.main.simulation.ssh.userhome.description"), ""), /** Serveur accessible par ssh : remote data path */ - SIMULATOR_SSH_DATAPATH("simulation.ssh.datapath", n_("isisfish.config.main.simulation.ssh.datapath.description"), "isis-fish" + majorVersion.toString() + "/isis-database"), + SIMULATOR_SSH_DATAPATH("simulation.ssh.datapath", n_("isisfish.config.main.simulation.ssh.datapath.description"), "isis-fish-" + majorVersion.toString() + "/isis-database"), /** Serveur accessible par ssh : remote isis home install */ SIMULATOR_SSH_ISIS_HOME("simulation.ssh.isis.home", n_("isisfish.config.main.simulation.ssh.isis.home.description"), "/home3/caparmor/poussin/isis-fish-" + IsisConfig.getApiVersion()), /** Serveur accessible par ssh : remote tmp path */

1 0

r3623 - in branches/4.1/src: main/java/fr/ifremer/isisfish/equation main/java/fr/ifremer/isisfish/util test/java/fr/ifremer/isisfish/util
by echatellier＠users.forge.codelutin.com March 2, 2012

March 2, 2012

Author: echatellier Date: 2012-03-02 10:51:52 +0100 (Fri, 02 Mar 2012) New Revision: 3623 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3623 Log: #841 : Utilisation de paranamer au lieu de l'annotation @Args Juste des tests (ca ne fonctionne pas avec paranamer) Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/equation/ImmigrationEquation.java branches/4.1/src/main/java/fr/ifremer/isisfish/util/ArgTypes.java branches/4.1/src/main/java/fr/ifremer/isisfish/util/Args.java branches/4.1/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java branches/4.1/src/main/java/fr/ifremer/isisfish/util/EvaluatorHelper.java branches/4.1/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java branches/4.1/src/test/java/fr/ifremer/isisfish/util/EvaluateHelperTest.java Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/equation/ImmigrationEquation.java =================================================================== --- branches/4.1/src/main/java/fr/ifremer/isisfish/equation/ImmigrationEquation.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/main/java/fr/ifremer/isisfish/equation/ImmigrationEquation.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -58,7 +58,7 @@ * d'arrivé pour le groupe passé en argument * @throws Exception */ - @Args({"context", "N", "pop", "group", "arrivalZone"}) + @Args({"context", "N", "pop", "group", "arrivalZone"}) public double compute(SimulationContext context, MatrixND N, Population pop, PopulationGroup group, Zone arrivalZone) throws Exception; Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/util/ArgTypes.java =================================================================== --- branches/4.1/src/main/java/fr/ifremer/isisfish/util/ArgTypes.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/main/java/fr/ifremer/isisfish/util/ArgTypes.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2006 - 2011 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric + * Copyright (C) 2006 - 2012 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -34,6 +34,8 @@ * Annotation utilisée pour specifier le type des parametres. * * Pour etre plus explicit que "List" en renseignant "List<Zone>" par exemple. + * + * Doit pouvoir être remplacé par l'introspection java sans problème. * * Created: 4 juil. 2006 12:40:46 * @@ -48,5 +50,3 @@ public @interface ArgTypes { String[] value(); } - - Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/util/Args.java =================================================================== --- branches/4.1/src/main/java/fr/ifremer/isisfish/util/Args.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/main/java/fr/ifremer/isisfish/util/Args.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2006 - 2011 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric + * Copyright (C) 2006 - 2012 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -33,6 +33,8 @@ /** * Annotation pour specifier le nom des arguments car il est impossible * de les avoir par introspection. + * Même via paranamer c'est impossible car sur les interfaces les noms + * ne sont pas présent dans le bytecode. * * Created: 4 juil. 2006 12:40:46 * @@ -47,5 +49,3 @@ public @interface Args { String[] value(); } - - Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java =================================================================== --- branches/4.1/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/main/java/fr/ifremer/isisfish/util/CompileHelper.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2006 - 2011 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric + * Copyright (C) 2006 - 2012 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -32,6 +32,7 @@ import java.lang.reflect.Method; import java.net.URL; import java.util.ArrayList; +import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.Enumeration; @@ -335,7 +336,6 @@ Args args = interfaceMethod.getAnnotation(Args.class); String[] names = args.value(); - String[] stringTypes = null; ArgTypes argTypes = interfaceMethod.getAnnotation(ArgTypes.class); if (argTypes != null) { @@ -343,6 +343,7 @@ } else { stringTypes = new String[names.length]; Class<?>[] types = interfaceMethod.getParameterTypes(); + System.out.println(Arrays.toString(types)); for (int i = 0; i < types.length; i++) { stringTypes[i] = types[i].getName(); } Modified: branches/4.1/src/main/java/fr/ifremer/isisfish/util/EvaluatorHelper.java =================================================================== --- branches/4.1/src/main/java/fr/ifremer/isisfish/util/EvaluatorHelper.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/main/java/fr/ifremer/isisfish/util/EvaluatorHelper.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2006 - 2010 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin + * Copyright (C) 2006 - 2012 Ifremer, Code Lutin, Cédric Pineau, Benjamin Poussin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as @@ -40,8 +40,8 @@ import org.apache.commons.logging.LogFactory; import org.nuiton.util.FileUtil; +import fr.ifremer.isisfish.IsisFish; import fr.ifremer.isisfish.IsisFishRuntimeException; -import fr.ifremer.isisfish.IsisFish; /** @@ -232,7 +232,7 @@ Args args = interfaceMethod.getAnnotation(Args.class); String [] names = args.value(); - + String [] stringTypes; ArgTypes argTypes = interfaceMethod.getAnnotation(ArgTypes.class); if (argTypes != null) { Modified: branches/4.1/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java =================================================================== --- branches/4.1/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/test/java/fr/ifremer/isisfish/util/CompileHelperTest.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -27,6 +27,7 @@ import java.io.File; import java.io.IOException; +import java.lang.reflect.Method; import java.net.URL; import java.net.URLClassLoader; import java.util.ArrayList; @@ -41,6 +42,7 @@ import org.junit.Test; import fr.ifremer.isisfish.AbstractIsisFishTest; +import fr.ifremer.isisfish.equation.PopulationReproductionEquation; /** * CompileHelperTest. @@ -238,4 +240,18 @@ nonUnicodeFile.delete(); }*/ + + /** + * Test que le contenu du fichier java correspondant à l'equation est + * corectement généré. + * Notemment suite à l'utilsation de paranamer et aux retrait des + * annotations. + */ + @Test + public void testExtractDoc() { + String content = CompileHelper.extractDoc("PopulationReproduction", "Test", PopulationReproductionEquation.class); + + Assert.assertTrue(content.contains("N : org.nuiton.math.matrix.MatrixND")); + Assert.assertTrue(content.contains("zones : java.util.List<Zone>")); + } } Modified: branches/4.1/src/test/java/fr/ifremer/isisfish/util/EvaluateHelperTest.java =================================================================== --- branches/4.1/src/test/java/fr/ifremer/isisfish/util/EvaluateHelperTest.java 2012-02-29 14:07:39 UTC (rev 3622) +++ branches/4.1/src/test/java/fr/ifremer/isisfish/util/EvaluateHelperTest.java 2012-03-02 09:51:52 UTC (rev 3623) @@ -25,6 +25,7 @@ package fr.ifremer.isisfish.util; +import java.lang.reflect.Method; import java.util.HashMap; import java.util.Map; @@ -35,6 +36,7 @@ import fr.ifremer.isisfish.equation.EmigrationEquation; import fr.ifremer.isisfish.equation.PopulationGrowth; import fr.ifremer.isisfish.equation.PopulationGrowthReverse; +import fr.ifremer.isisfish.equation.PopulationReproductionEquation; /** * Test class for {@link EvaluatorHelper}. @@ -153,4 +155,21 @@ Assert.assertNotNull(result); Assert.assertEquals("1.0", result.toString()); } + + /** + * Test que le contenu du fichier java correspondant à l'equation est + * corectement généré. + * Notemment suite à l'utilsation de paranamer et aux retrait des + * annotations. + */ + @Test + public void testGenerateContent() { + Class clazz = PopulationReproductionEquation.class; + Method method = clazz.getDeclaredMethods()[0]; + String content = EvaluatorHelper.generateContent("fr.ifremer.isisfish.equation", + "Test", method, "return 42.0;"); + + Assert.assertTrue(content.contains("fr.ifremer.isisfish.simulator.SimulationContext context")); + Assert.assertTrue(content.contains("java.util.List<PopulationGroup> groups")); + } }

1 0

r3622 - trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher
by echatellier＠users.forge.codelutin.com Feb. 29, 2012

Feb. 29, 2012

Author: echatellier Date: 2012-02-29 15:07:39 +0100 (Wed, 29 Feb 2012) New Revision: 3622 Url: http://forge.codelutin.com/repositories/revision/isis-fish/3622 Log: Fix simulation end message Modified: trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/SimulationMonitor.java Modified: trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/SimulationMonitor.java =================================================================== --- trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/SimulationMonitor.java 2012-02-29 13:42:52 UTC (rev 3621) +++ trunk/src/main/java/fr/ifremer/isisfish/simulator/launcher/SimulationMonitor.java 2012-02-29 14:07:39 UTC (rev 3622) @@ -712,6 +712,8 @@ } } } + + control.setText(_("isisfish.message.simulation.ended")); } }

1 0