Author: echatellier Date: 2013-02-04 12:03:37 +0100 (Mon, 04 Feb 2013) New Revision: 72 Url: http://forge.codelutin.com/projects/cantharella/repository/revisions/72 Log: Various quality fix Modified: trunk/cantharella.service/src/main/java/nc/ird/cantharella/service/services/impl/PersonneServiceImpl.java trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/campagne/ManageCampagnePage.java trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/config/ListConfigurationPage.java Modified: trunk/cantharella.service/src/main/java/nc/ird/cantharella/service/services/impl/PersonneServiceImpl.java =================================================================== --- trunk/cantharella.service/src/main/java/nc/ird/cantharella/service/services/impl/PersonneServiceImpl.java 2013-02-04 10:57:28 UTC (rev 71) +++ trunk/cantharella.service/src/main/java/nc/ird/cantharella/service/services/impl/PersonneServiceImpl.java 2013-02-04 11:03:37 UTC (rev 72) @@ -312,7 +312,7 @@ * {@inheritDoc} */ @Override - public void rejectUtilisateur(Utilisateur utilisateur) throws NoSuchMessageException { + public void rejectUtilisateur(Utilisateur utilisateur) { try { deleteUtilisateur(utilisateur, messages.getMessage("reject.subject"), messages.getMessage("reject.text")); } catch (EmailException e) { Modified: trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/campagne/ManageCampagnePage.java =================================================================== --- trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/campagne/ManageCampagnePage.java 2013-02-04 10:57:28 UTC (rev 71) +++ trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/campagne/ManageCampagnePage.java 2013-02-04 11:03:37 UTC (rev 72) @@ -711,7 +711,7 @@ List<String> dateErrors = validator.validate(campagneModel.getObject(), getSession().getLocale(), "dateDeb", "dateFin"); addValidationErrors(dateErrors); - if (dateErrors.size() == 0 + if (dateErrors.isEmpty() && (campagneModel.getObject().getDateDeb() == null || campagneModel.getObject().getDateFin() == null || !campagneModel .getObject().getDateDeb().before(campagneModel.getObject().getDateFin()))) { getPage().error(getString("Campagne.dates.KO")); Modified: trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/config/ListConfigurationPage.java =================================================================== --- trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/config/ListConfigurationPage.java 2013-02-04 10:57:28 UTC (rev 71) +++ trunk/cantharella.web/src/main/java/nc/ird/cantharella/web/pages/domain/config/ListConfigurationPage.java 2013-02-04 11:03:37 UTC (rev 72) @@ -45,7 +45,7 @@ public final class ListConfigurationPage extends TemplatePage { /** The opened param value */ - final private String OPENED_PARAM_VALUE = "opened"; + private static final String OPENED_PARAM_VALUE = "opened"; /** * Constructor