branch develop updated (7109875 -> 5e7b646)
This is an automated email from the git hooks/post-receive script. New change to branch develop in repository coser. See https://gitlab.nuiton.org/codelutin/coser.git from 7109875 Update .gitlab-ci.yml new 5e7b646 Fix sonar vulnerabilities The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Detailed log of new commits: commit 5e7b646254d68efa6374e370d733b820f9933074 Author: jcouteau <couteau@codelutin.com> Date: Thu Jan 10 15:49:28 2019 +0100 Fix sonar vulnerabilities Summary of changes: .../main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java | 2 +- .../src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java | 2 +- .../src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository coser. See https://gitlab.nuiton.org/codelutin/coser.git commit 5e7b646254d68efa6374e370d733b820f9933074 Author: jcouteau <couteau@codelutin.com> Date: Thu Jan 10 15:49:28 2019 +0100 Fix sonar vulnerabilities --- .../main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java | 2 +- .../src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java | 2 +- .../src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/coser-business/src/main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java b/coser-business/src/main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java index ab61914..09c3c69 100644 --- a/coser-business/src/main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java +++ b/coser-business/src/main/java/fr/ifremer/coser/command/MergeSpeciesCommand.java @@ -68,7 +68,7 @@ public class MergeSpeciesCommand extends Command { } public void setSpeciesNames(String[] speciesNames) { - this.speciesNames = speciesNames; + this.speciesNames = speciesNames.clone(); } /* diff --git a/coser-business/src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java b/coser-business/src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java index d0c736b..1005948 100644 --- a/coser-business/src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java +++ b/coser-business/src/main/java/fr/ifremer/coser/data/AbstractDataEntity.java @@ -47,7 +47,7 @@ public abstract class AbstractDataEntity extends AbstractEntity { } public void setData(String[] data) { - this.data = data; + this.data = data.clone(); } public void setLine(String value) { diff --git a/coser-web/src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java b/coser-web/src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java index a6e973e..e93b795 100644 --- a/coser-web/src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java +++ b/coser-web/src/main/java/fr/ifremer/coser/web/actions/map/MapAction.java @@ -27,6 +27,8 @@ import fr.ifremer.coser.result.request.GetMatchingRepositoryTypeForMapResultRequ import fr.ifremer.coser.result.request.GetSpeciesForMapResultRequest; import fr.ifremer.coser.result.request.GetZonesForMapResultRequest; import fr.ifremer.coser.web.actions.common.AbstractCoserJspAction; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; /** * Action index, recupere la liste des resultats. @@ -35,6 +37,9 @@ import fr.ifremer.coser.web.actions.common.AbstractCoserJspAction; */ public class MapAction extends AbstractCoserJspAction { + /** Logger. */ + private static final Log log = LogFactory.getLog(MapAction.class); + private static final long serialVersionUID = 1663244944108703571L; protected String facade; @@ -105,7 +110,7 @@ public class MapAction extends AbstractCoserJspAction { try { matchingrepositoryType = getService().getMatchingRepositoryType(request); } catch (Exception e) { - e.printStackTrace(); + log.error("Error getting matching repository type", e); } } return matchingrepositoryType; -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
participants (1)
-
codelutin.com scm