Author: tchemit Date: 2012-01-13 18:06:50 +0100 (Fri, 13 Jan 2012) New Revision: 275 Url: http://forge.codelutin.com/repositories/revision/echobase/275 Log: fix sonar errors Modified: trunk/echobase-services/src/main/java/fr/ifremer/echobase/services/configurations/EmbeddedApplicationConfiguration.java trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/CellLoader.java trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/EntityLoader.java Modified: trunk/echobase-services/src/main/java/fr/ifremer/echobase/services/configurations/EmbeddedApplicationConfiguration.java =================================================================== --- trunk/echobase-services/src/main/java/fr/ifremer/echobase/services/configurations/EmbeddedApplicationConfiguration.java 2012-01-13 15:49:20 UTC (rev 274) +++ trunk/echobase-services/src/main/java/fr/ifremer/echobase/services/configurations/EmbeddedApplicationConfiguration.java 2012-01-13 17:06:50 UTC (rev 275) @@ -27,6 +27,7 @@ import java.io.File; import java.io.IOException; +import java.util.Arrays; /** * Configuration of a embedded application creation. @@ -82,7 +83,7 @@ } public void setVoyageIds(String[] voyageIds) { - this.voyageIds = voyageIds; + this.voyageIds = Arrays.copyOf(voyageIds, voyageIds.length); } public File getWarLocation() { Modified: trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/CellLoader.java =================================================================== --- trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/CellLoader.java 2012-01-13 15:49:20 UTC (rev 274) +++ trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/CellLoader.java 2012-01-13 17:06:50 UTC (rev 275) @@ -90,7 +90,7 @@ /** Logger. */ private static final Log log = LogFactory.getLog(CellLoader.class); - public static final DateFormat DATE_FORMAT = + public final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss'Z'"); public static final String SURF_REGION = "SURF"; @@ -461,7 +461,7 @@ // already treated continue; } - String cellStringId = DATE_FORMAT.format(cellId); + String cellStringId = dateFormat.format(cellId); if (log.isDebugEnabled()) { log.debug("Treat esdu " + cellStringId); } @@ -493,7 +493,7 @@ continue; } - String cellStringId = DATE_FORMAT.format(cellId); + String cellStringId = dateFormat.format(cellId); if (log.isDebugEnabled()) { log.debug("Treat esdu " + cellStringId); } Modified: trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/EntityLoader.java =================================================================== --- trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/EntityLoader.java 2012-01-13 15:49:20 UTC (rev 274) +++ trunk/echobase-tools/src/main/java/fr/ifremer/echobase/tools/loaders/EntityLoader.java 2012-01-13 17:06:50 UTC (rev 275) @@ -64,6 +64,7 @@ import java.io.Reader; import java.io.Writer; import java.text.ParseException; +import java.util.Arrays; import java.util.List; import java.util.Map; import java.util.Set; @@ -127,7 +128,8 @@ this.fileTypes = Sets.newHashSet(fileTypes); this.parent = parent; this.parentAssociationName = parentAssociationName; - this.extraDependencies = extraDependencies; + Preconditions.checkNotNull(extraDependencies); + this.extraDependencies = Arrays.copyOf(extraDependencies, extraDependencies.length); } @Override