May 2013 - Franciaflex-magalie-commits - mailman.cloud.codelutin.com

r178 - in trunk: magalie-services/src/main/java/com/franciaflex/magalie/services/service magalie-services/src/test/java/com/franciaflex/magalie/services/service magalie-web/src/main/java/com/franciaflex/magalie/web/action
by bleny＠users.forge.codelutin.com 22 May '13

22 May '13

Author: bleny Date: 2013-05-22 14:30:18 +0200 (Wed, 22 May 2013) New Revision: 178 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: fixes #2452 notify user when requested list is complete Modified: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/RequestedArticleServiceTest.java trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/action/WithdrawItemAction.java Modified: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java =================================================================== --- trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java 2013-05-22 09:01:57 UTC (rev 177) +++ trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java 2013-05-22 12:30:18 UTC (rev 178) @@ -30,6 +30,7 @@ import com.franciaflex.magalie.persistence.dao.DeliveredRequestedListDao; import com.franciaflex.magalie.persistence.dao.RequestedArticleDao; import com.franciaflex.magalie.persistence.dao.RequestedListDao; +import com.franciaflex.magalie.persistence.dao.StorageMovementOrderDao; import com.franciaflex.magalie.persistence.entity.Article; import com.franciaflex.magalie.persistence.entity.Building; import com.franciaflex.magalie.persistence.entity.DeliveredRequestedArticle; @@ -326,26 +327,23 @@ public void onStorageMovementConfirmation(StorageMovementOrder storageMovementOrder) { - MagaliePersistenceContext persistenceContext = - serviceContext.getPersistenceContext(); + MagaliePersistenceContext persistenceContext = serviceContext.getPersistenceContext(); - DeliveredRequestedArticleDao deliveredRequestedArticleDao = - persistenceContext.getDeliveredRequestedArticleDao(); + DeliveredRequestedList deliveredRequestedList = getDeliveredRequestedList(storageMovementOrder.getId()); - DeliveredRequestedArticle deliveredRequestedArticle = - deliveredRequestedArticleDao.find(storageMovementOrder); + if (deliveredRequestedList != null) { - if (deliveredRequestedArticle != null) { - // a order is confirmed and this order is about a requested article // so we may update the status of the list - RequestedList requestedList = - deliveredRequestedArticle.getRequestedArticle().getRequestedList(); + RequestedList requestedList = deliveredRequestedList.getRequestedList(); RequestedArticleDao requestedArticleDao = persistenceContext.getRequestedArticleDao(); + DeliveredRequestedArticleDao deliveredRequestedArticleDao = + persistenceContext.getDeliveredRequestedArticleDao(); + List<RequestedArticle> requestedArticles = requestedArticleDao.findAll(requestedList); @@ -364,16 +362,8 @@ + requestedList.getCode() + " as complete"); } - DeliveredRequestedListDao deliveredRequestedListDao = - persistenceContext.getDeliveredRequestedListDao(); - - DeliveredRequestedList deliveredRequestedList = - deliveredRequestedListDao.findByRequestedList(requestedList); - deliveredRequestedList.setStatus(DeliveredRequestedListStatus.COMPLETE); - // TODO brendan 25/04/13 notify user - } } @@ -440,4 +430,44 @@ return allDistinctListTypes; } + + /** + * @return null if storage movement order is not about a requested-list (for example, kanban) + */ + public DeliveredRequestedList getDeliveredRequestedList(String storageMovementOrderId) { + + MagaliePersistenceContext persistenceContext = + serviceContext.getPersistenceContext(); + + DeliveredRequestedArticleDao deliveredRequestedArticleDao = + persistenceContext.getDeliveredRequestedArticleDao(); + + StorageMovementOrderDao storageMovementOrderDao = + persistenceContext.getStorageMovementOrderDao(); + + StorageMovementOrder storageMovementOrder = + storageMovementOrderDao.findById(storageMovementOrderId); + + DeliveredRequestedArticle deliveredRequestedArticle = + deliveredRequestedArticleDao.find(storageMovementOrder); + + DeliveredRequestedList deliveredRequestedList = null; + + if (deliveredRequestedArticle != null) { + + RequestedList requestedList = + deliveredRequestedArticle.getRequestedArticle().getRequestedList(); + + DeliveredRequestedListDao deliveredRequestedListDao = + persistenceContext.getDeliveredRequestedListDao(); + + deliveredRequestedList = + deliveredRequestedListDao.findByRequestedList(requestedList); + + } + + return deliveredRequestedList; + + } + } Modified: trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/RequestedArticleServiceTest.java =================================================================== --- trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/RequestedArticleServiceTest.java 2013-05-22 09:01:57 UTC (rev 177) +++ trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/RequestedArticleServiceTest.java 2013-05-22 12:30:18 UTC (rev 178) @@ -24,8 +24,11 @@ */ import com.franciaflex.magalie.persistence.entity.Building; +import com.franciaflex.magalie.persistence.entity.DeliveredRequestedList; +import com.franciaflex.magalie.persistence.entity.DeliveredRequestedListStatus; import com.franciaflex.magalie.persistence.entity.MagalieUser; import com.franciaflex.magalie.persistence.entity.RequestedArticle; +import com.franciaflex.magalie.persistence.entity.StorageMovementOrder; import com.franciaflex.magalie.services.AbstractMagalieServiceTest; import com.google.common.base.Preconditions; import com.google.common.collect.Iterables; @@ -223,4 +226,47 @@ } + @Test + public void testCompleteStatusIsReachable() throws Exception { + + FindOrderToExecuteResult orderToExecute; + StorageMovementOrder storageMovementOrder; + DeliveredRequestedList deliveredRequestedList; + + // we will process a requested list with to articles to checks that the state is updated + + // first article + + { + + orderToExecute = service.findOrderToExecute(magalieUser, building, LIST_TYPE); + + Preconditions.checkState(orderToExecute.isSuccess()); + + storageMovementOrder = orderToExecute.getStorageMovementOrder(); + + service.onStorageMovementConfirmation(storageMovementOrder); + + deliveredRequestedList = service.getDeliveredRequestedList(storageMovementOrder.getId()); + + Assert.assertNotEquals(DeliveredRequestedListStatus.COMPLETE, deliveredRequestedList.getStatus()); + + } + + // now treat last article of the list to make it complete + + orderToExecute = service.findOrderToExecute(magalieUser, building, LIST_TYPE); + + Preconditions.checkState(orderToExecute.isSuccess()); + + storageMovementOrder = orderToExecute.getStorageMovementOrder(); + + service.onStorageMovementConfirmation(storageMovementOrder); + + deliveredRequestedList = service.getDeliveredRequestedList(storageMovementOrder.getId()); + + Assert.assertNotEquals(DeliveredRequestedListStatus.COMPLETE, deliveredRequestedList.getStatus()); + + } + } Modified: trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/action/WithdrawItemAction.java =================================================================== --- trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/action/WithdrawItemAction.java 2013-05-22 09:01:57 UTC (rev 177) +++ trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/action/WithdrawItemAction.java 2013-05-22 12:30:18 UTC (rev 178) @@ -24,10 +24,13 @@ */ import com.franciaflex.magalie.MagalieTechnicalException; +import com.franciaflex.magalie.persistence.entity.DeliveredRequestedList; +import com.franciaflex.magalie.persistence.entity.DeliveredRequestedListStatus; import com.franciaflex.magalie.persistence.entity.MagalieUser; import com.franciaflex.magalie.services.StorageMovementConfirmation; import com.franciaflex.magalie.services.StorageMovementTask; import com.franciaflex.magalie.services.service.ArticleStorageService; +import com.franciaflex.magalie.services.service.RequestedArticleService; import com.franciaflex.magalie.web.MagalieActionSupport; import com.franciaflex.magalie.web.MagalieSession; import com.google.common.base.Preconditions; @@ -49,8 +52,10 @@ private static final Log log = LogFactory.getLog(WithdrawItemAction.class); - protected ArticleStorageService service; + protected ArticleStorageService articleStorageService; + protected RequestedArticleService requestedArticleService; + protected String storageMovementOrderId; protected StorageMovementTask storageMovementTask; @@ -63,10 +68,14 @@ this.session = session; } - public void setService(ArticleStorageService service) { - this.service = service; + public void setArticleStorageService(ArticleStorageService articleStorageService) { + this.articleStorageService = articleStorageService; } + public void setRequestedArticleService(RequestedArticleService requestedArticleService) { + this.requestedArticleService = requestedArticleService; + } + public void setStorageMovementOrderId(String storageMovementOrderId) { this.storageMovementOrderId = storageMovementOrderId; } @@ -76,7 +85,7 @@ Preconditions.checkNotNull(storageMovementOrderId); - storageMovementTask = service.getStorageMovementTask(storageMovementOrderId); + storageMovementTask = articleStorageService.getStorageMovementTask(storageMovementOrderId); return INPUT; @@ -118,10 +127,23 @@ MagalieUser magalieUser = session.getMagalieUser(); - service.confirmStorageMovement(confirmation, magalieUser); + articleStorageService.confirmStorageMovement(confirmation, magalieUser); String resultName = session.getActivity().name(); + DeliveredRequestedList deliveredRequestedList = + requestedArticleService.getDeliveredRequestedList(confirmation.getStorageMovementOrderId()); + + if (deliveredRequestedList != null) { + + if (deliveredRequestedList.getStatus() == DeliveredRequestedListStatus.COMPLETE) { + + session.addMessage("La liste " + deliveredRequestedList.getRequestedList().getCode() + " est terminée"); + + } + + } + return resultName; }

1 0

r177 - trunk/magalie-web/src/main/webapp/css
by bleny＠users.forge.codelutin.com 22 May '13

22 May '13

Author: bleny Date: 2013-05-22 11:01:57 +0200 (Wed, 22 May 2013) New Revision: 177 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2431 prevent bad vertical scrolling Modified: trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css Modified: trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css =================================================================== --- trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 08:53:50 UTC (rev 176) +++ trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 09:01:57 UTC (rev 177) @@ -28,8 +28,6 @@ #container { position: absolute; width: 230px; - height: 320px; - overflow: auto; background-color: white; margin-top: 30px; margin-left: 5px;

1 0

r176 - in trunk/magalie-web/src/main: java/com/franciaflex/magalie/web webapp/WEB-INF/content webapp/WEB-INF/decorators webapp/css
by Bavencoff＠users.forge.codelutin.com 22 May '13

22 May '13

Author: Bavencoff Date: 2013-05-22 10:53:50 +0200 (Wed, 22 May 2013) New Revision: 176 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2431 : user experience Modified: trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css Modified: trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java =================================================================== --- trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java 2013-05-22 07:19:40 UTC (rev 175) +++ trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java 2013-05-22 08:53:50 UTC (rev 176) @@ -42,4 +42,9 @@ public List<String> getShortcuts () { return SHORTCUTS; } + + public boolean isWithMessages() { + return super.hasActionErrors() || super.hasActionMessages(); + } + } Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp 2013-05-22 07:19:40 UTC (rev 175) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp 2013-05-22 08:53:50 UTC (rev 176) @@ -55,10 +55,9 @@ </div> </s:form> <div id="locationTemplate" class="template"> - <dl class="dl-horizontal"> - <dt>Empl.</dt> - <dd><span data="warehouse.code"></span> <span data="code"></span></dd> - <dt>Prélev.</dt> - <dd><span data="stored">0</span> <s:property value="receptionTask.storedArticle.article.unit" /></dd> - </dl> + <div> + <span data="warehouse.code"></span> + <span data="code"></span> + <span data="stored">0</span> <s:property value="receptionTask.storedArticle.article.unit" /> + </div> </div> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp 2013-05-22 07:19:40 UTC (rev 175) +++ trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp 2013-05-22 08:53:50 UTC (rev 176) @@ -41,11 +41,18 @@ </head> <body> <div id="container"> - - <s:actionerror theme="bootstrap"/> - <s:actionmessage theme="bootstrap"/> - <s:fielderror theme="bootstrap"/> - + <s:if test="withMessages" > + <script type="text/javascript"> + $(document).ready(function () { + <s:iterator value="actionMessages" var="actionMessage" > + alert('<s:property value="#actionMessage" escapeJavaScript="true" escapeHtml="false" />'); + </s:iterator> + <s:iterator value="actionErrors" var="actionError" > + alert('<s:property value="#actionError" escapeJavaScript="true" escapeHtml="false"/>'); + </s:iterator> + }); + </script> + </s:if> <decorator:body /> </div> </body> Modified: trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css =================================================================== --- trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 07:19:40 UTC (rev 175) +++ trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 08:53:50 UTC (rev 176) @@ -27,8 +27,6 @@ #container { position: absolute; - #left: 5px; - #top: 5px; width: 230px; height: 320px; overflow: auto;

1 0

r175 - trunk/magalie-web/src/main/webapp/css
by Bavencoff＠users.forge.codelutin.com 22 May '13

22 May '13

Author: Bavencoff Date: 2013-05-22 09:19:40 +0200 (Wed, 22 May 2013) New Revision: 175 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2431 : user experience Modified: trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css Modified: trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css =================================================================== --- trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 07:02:15 UTC (rev 174) +++ trunk/magalie-web/src/main/webapp/css/magalie-ck3x.css 2013-05-22 07:19:40 UTC (rev 175) @@ -27,8 +27,8 @@ #container { position: absolute; - left: 5px; - top: 5px; + #left: 5px; + #top: 5px; width: 230px; height: 320px; overflow: auto;

1 0

r174 - in trunk/magalie-web/src/main: java/com/franciaflex/magalie/web webapp/WEB-INF/content webapp/WEB-INF/decorators webapp/js
by Bavencoff＠users.forge.codelutin.com 22 May '13

22 May '13

Author: Bavencoff Date: 2013-05-22 09:02:15 +0200 (Wed, 22 May 2013) New Revision: 174 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2431 : shortcuts Modified: trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java trunk/magalie-web/src/main/webapp/WEB-INF/content/choose-activity.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/deliver-requested-article-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/fulfil-kanban-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/content/withdraw-item-input.jsp trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp trunk/magalie-web/src/main/webapp/js/magalie.js trunk/magalie-web/src/main/webapp/js/receive-article-input.js trunk/magalie-web/src/main/webapp/js/withdraw-item-input.js Modified: trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java =================================================================== --- trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/java/com/franciaflex/magalie/web/MagalieActionSupport.java 2013-05-22 07:02:15 UTC (rev 174) @@ -27,10 +27,19 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import java.util.Arrays; +import java.util.List; + public class MagalieActionSupport extends ActionSupport { private static final long serialVersionUID = 1L; private static final Log log = LogFactory.getLog(MagalieActionSupport.class); + public static final List<String> SHORTCUTS = Arrays.asList(new String[]{ "0", "1", "2", "3", "5", "6", "7", "8", "9", + "a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", + "w", "x", "y", "z" }); + public List<String> getShortcuts () { + return SHORTCUTS; + } } Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/choose-activity.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/choose-activity.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/choose-activity.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -33,9 +33,13 @@ <head> <script> -$(document).keydown(function(event) { -alert('Touche :' + event.which); +$(document).ready(function() { + bindKey('1', function(){ redirectTo($('#fulfilKanbanlink'));}); + bindKey('2', function(){ redirectTo($('#deliverRequestedArticlelink'));}); + bindKey('3', function(){ redirectTo($('#prepareArticleReceptionlink'));}); + bindKey('Esc', function(){ redirectTo($('#logoutlink'));}); }); + </script> </head> @@ -49,7 +53,7 @@ </dl> </header> -<s:a href="%{fulfilKanbanUrl}" cssClass="btn btn-block">Traiter kanbans</s:a> -<s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block">Traiter listes à servir</s:a> -<s:a href="%{prepareArticleReceptionUrl}" cssClass="btn btn-block">Traiter les réceptions fournisseurs</s:a> -<s:a href="%{logoutUrl}" cssClass="btn btn-block">Déconnexion</s:a> +<s:a href="%{fulfilKanbanUrl}" cssClass="btn btn-block" id="fulfilKanbanlink">Traiter kanbans (1)</s:a> +<s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block" id="deliverRequestedArticlelink">Traiter listes à servir (2)</s:a> +<s:a href="%{prepareArticleReceptionUrl}" cssClass="btn btn-block" id="prepareArticleReceptionlink" >Traiter les réceptions fournisseurs (3)</s:a> +<s:a href="%{logoutUrl}" cssClass="btn btn-block" id="logoutlink" >Déconnexion (Esc)</s:a> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/deliver-requested-article-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/deliver-requested-article-input.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/deliver-requested-article-input.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -24,13 +24,12 @@ <%@ taglib prefix="s" uri="/struts-tags" %> <s:if test="requestedList"> - <head> <script type="text/javascript"> $(document).ready(function () { $("#requestedArticle").focus(); + bindKey('0', function(){ redirectTo($('#requestedArticle'));}); }); - </script> - </head> + </script> <p> Vous êtes affecté à la liste <s:property value="requestedList.code" /> @@ -38,18 +37,40 @@ <s:url namespace="/" action="deliver-requested-article" id="deliverRequestedArticleUrl"> <s:param name="listType" value="%{requestedList.listType}" /> </s:url> - <s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block" id="requestedArticle" >Demander un article à servir</s:a> + <s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block" id="requestedArticle" >Demander un article à servir (0)</s:a> </s:if> <s:else> - <s:iterator value="listTypes" var="listType"> + <s:iterator value="listTypes" var="listType" status="stat"> + <s:set var="deliverRequestedArticleId">prepareArticleReceptionId<s:property value="#stat.index" /></s:set> <s:url namespace="/" action="deliver-requested-article" id="deliverRequestedArticleUrl"> <s:param name="listType" value="#listType" /> </s:url> - <s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block"> - Commencer à traiter une liste « <s:property value="#listType" /> » - </s:a> + <s:if test="#stat.index < shortcuts.size()"> + <script type="text/javascript"> + $(document).ready(function () { + var id = '<s:property value="deliverRequestedArticleId" />'; + bindKey(<s:property value="shortcuts.get(#stat.index)" />, function(){ redirectTo($('#' + id));}); + }); + </script> + <s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block" id="%{deliverRequestedArticleId}"> + Commencer à traiter une liste « <s:property value="#listType" /> » + (<s:property value="shortcuts.get(#stat.index)" />) + </s:a> + </s:if> + <s:else> + <s:a href="%{deliverRequestedArticleUrl}" cssClass="btn btn-block"> + Commencer à traiter une liste « <s:property value="#listType" /> » + </s:a> + </s:else> </s:iterator> </s:else> +<script type="text/javascript"> + $(document).ready(function () { + $("#requestedArticle").focus(); + bindKey('Esc', function(){ redirectTo($('#removeUserAffectationLink'));}); + }); +</script> + <s:url namespace="/" action="remove-user-affectation" id="removeUserAffectationUrl"/> -<s:a href="%{removeUserAffectationUrl}" cssClass="btn btn-block">Changer d'activité</s:a> +<s:a href="%{removeUserAffectationUrl}" cssClass="btn btn-block" id="removeUserAffectationLink">Changer d'activité (Esc)</s:a> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/fulfil-kanban-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/fulfil-kanban-input.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/fulfil-kanban-input.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -28,6 +28,7 @@ <script type="text/javascript"> $(document).ready(function () { $("#fulfil-kanban_articleBarcode").focus(); + bindKey('Esc', function(){ redirectTo($('#chooseActivityLink'));}); }); </script> </head> @@ -50,7 +51,7 @@ </s:if> <div class="btn-group"> - <s:a href="%{chooseActivityUrl}" cssClass="btn">Changer d'activité</s:a> + <s:a href="%{chooseActivityUrl}" cssClass="btn" id="chooseActivityLink" >Changer d'activité (Esc)</s:a> <s:submit name="next" value="Suivant" cssClass="btn btn-primary" /> </div> </s:form> \ No newline at end of file Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception-input.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception-input.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -23,24 +23,57 @@ <%@ page language="java" contentType="text/html; charset=utf-8" pageEncoding="utf-8" %> <%@ taglib prefix="s" uri="/struts-tags" %> + + +<head> + <script type="text/javascript"> + $(document).ready(function () { + bindKey('Esc', function(){ redirectTo($('#chooseActivityLink'));}); + }); + </script> +</head> + <s:if test="suppliersToReceive.somethingToReceive"> <ul> - <s:iterator value="suppliersToReceive.suppliers"> + <li> + <script type="text/javascript"> + $(document).ready(function () { + bindKey(<s:property value="shortcuts.get(0)" />, function(){ redirectTo($('#prepareArticleReceptionLink'));}); + }); + </script> + <s:url namespace="/" action="prepare-article-reception" id="prepareArticleReceptionUrl" /> + <s:a href="%{prepareArticleReceptionUrl}" id="prepareArticleReceptionLink"> + Tous les fournisseurs (<s:property value="shortcuts.get(0)" />) + </s:a> + </li> + + <s:iterator value="suppliersToReceive.suppliers" status="stat"> <li> + <s:set var="prepareArticleReceptionId">prepareArticleReceptionId<s:property value="#stat.index" /></s:set> <s:url namespace="/" action="prepare-article-reception" id="prepareArticleReceptionUrl"> - <s:param name="supplierId" value="%{id}" /> - </s:url> - <s:a href="%{prepareArticleReceptionUrl}"><s:property value="name" /></s:a> + <s:param name="supplierId" value="%{id}" /> + </s:url> + <s:if test="#stat.index + 1 < shortcuts.size()"> + <script type="text/javascript"> + $(document).ready(function () { + var id = '<s:property value="prepareArticleReceptionId" />'; + bindKey(<s:property value="shortcuts.get(#stat.index + 1)" />, function(){ redirectTo($('#' + id));}); + }); + </script> + <s:a href="%{prepareArticleReceptionUrl}" id="%{prepareArticleReceptionId}"> + <s:property value="name" /> (<s:property value="shortcuts.get(#stat.index + 1)" />) + </s:a> + </s:if> + <s:else> + <s:a href="%{prepareArticleReceptionUrl}" > + <s:property value="name" /> + </s:a> + </s:else> </li> </s:iterator> - <li> - <s:url namespace="/" action="prepare-article-reception" id="prepareArticleReceptionUrl" /> - <s:a href="%{prepareArticleReceptionUrl}"> - Tous les fournisseurs - </s:a> - </li> + </ul> </s:if> <s:url namespace="/" action="choose-activity" id="chooseActivityUrl"/> -<s:a href="%{chooseActivityUrl}" cssClass="btn">Changer d'activité</s:a> +<s:a href="%{chooseActivityUrl}" cssClass="btn" id="chooseActivityLink">Changer d'activité (Esc)</s:a> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/prepare-article-reception.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -24,17 +24,37 @@ <%@ taglib prefix="s" uri="/struts-tags" %> <ul> - <s:iterator value="receivedArticles"> - <li> - <s:url namespace="/" action="receive-article!input" id="receiveArticleUrl"> - <s:param name="storedArticleId" value="%{id}" /> - </s:url> - <s:a href="%{receiveArticleUrl}"> - <s:property value="quantity" /> - <s:property value="article.unit" /> - <s:property value="article.description" /> - (Réf <s:property value="article.code" />) - </s:a> - </li> + <s:iterator value="receivedArticles" status="stat" > + <s:set var="receiveArticleId">prepareArticleReceptionId<s:property value="#stat.index" /></s:set> + <s:url namespace="/" action="receive-article!input" id="receiveArticleUrl"> + <s:param name="storedArticleId" value="%{id}" /> + </s:url> + <s:if test="#stat.index < shortcuts.size()"> + <script type="text/javascript"> + $(document).ready(function () { + var id = '<s:property value="receiveArticleId" />'; + bindKey(<s:property value="shortcuts.get(#stat.index)" />, function(){ redirectTo($('#' + id));}); + }); + </script> + <li> + <s:a href="%{receiveArticleUrl}" id="%{receiveArticleId}"> + <s:property value="quantity" /> + <s:property value="article.unit" /> + <s:property value="article.description" /> + (Réf <s:property value="article.code" />) + (<s:property value="shortcuts.get(#stat.index)" />) + </s:a> + </li> + </s:if> + <s:else> + <li> + <s:a href="%{receiveArticleUrl}"> + <s:property value="quantity" /> + <s:property value="article.unit" /> + <s:property value="article.description" /> + (Réf <s:property value="article.code" />) + </s:a> + </li> + </s:else> </s:iterator> </ul> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/receive-article-input.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -24,7 +24,6 @@ <%@ taglib prefix="s" uri="/struts-tags" %> <head> - <script src="<s:url value='/js/magalie.js' />"></script> <script> var model = <s:property value="modelAsJson" escapeHtml="false" />; </script> @@ -51,7 +50,7 @@ <s:hidden name="confirmation" /> <div class="btn-group"> - <s:submit name="full" value="Plein" cssClass="btn btn-danger btn-small" /> + <input type="button" name="full" value="Plein (F5)" class="btn btn-danger btn-small" id="receive-article_full" /> <s:submit name="next" value="Suivant" cssClass="btn btn-primary btn-small" /> </div> </s:form> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/content/withdraw-item-input.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/content/withdraw-item-input.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/content/withdraw-item-input.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -24,7 +24,6 @@ <%@ taglib prefix="s" uri="/struts-tags" %> <head> - <script src="<s:url value='/js/magalie.js' />"></script> <script> var model = <s:property value="modelAsJson" escapeHtml="false" />; </script> @@ -51,7 +50,7 @@ <s:hidden name="confirmation" /> <div class="btn-group"> - <input type="button" id="reportError" value="Anomalie" class="btn btn-danger btn-small" /> + <input type="button" id="reportError" value="Anomalie (F5)" class="btn btn-danger btn-small" /> <s:submit name="next" value="Suivant" cssClass="btn btn-primary btn-small" /> </div> </s:form> Modified: trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp =================================================================== --- trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/WEB-INF/decorators/layout.jsp 2013-05-22 07:02:15 UTC (rev 174) @@ -33,6 +33,7 @@ <sj:head locale="fr" jqueryui="false" jquerytheme="start" /> <sb:head /> <title><decorator:title default="MagaLiE"/> - MagaLiE</title> + <script src="<s:url value='/js/magalie.js' />"></script> <link rel="stylesheet" href="<s:url value='/css/magalie.css' />"/> <link rel="stylesheet" href="<s:url value='/css/magalie-ck3x.css' />"/>  Modified: trunk/magalie-web/src/main/webapp/js/magalie.js =================================================================== --- trunk/magalie-web/src/main/webapp/js/magalie.js 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/js/magalie.js 2013-05-22 07:02:15 UTC (rev 174) @@ -20,6 +20,71 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. * #L% */ + +// declaration des constantes de touche clavier + +KEYS = {"F1": 112, + "F2": 113, + "F3" : 114 , + "F4" : 115 , + "F5" : 116 , + "tab" : 9 , + "del" : 8 , + "Esc" : 27 , + "0" : 48, + "1" : 49, + "2" : 50, + "3" : 51, + "4" : 52, + "5" : 53, + "6" : 54, + "7" : 55, + "8" : 56, + "9" : 57, + "." : 190, + "a" : 65, + "b" : 66, + "c" : 67, + "d" : 68, + "e" : 69, + "f" : 70, + "g" : 71, + "h" : 72, + "i" : 73, + "j" : 74, + "k" : 75, + "l" : 76, + "m" : 77, + "n" : 78, + "o" : 79, + "p" : 80, + "q" : 81, + "r" : 82, + "s" : 83, + "t" : 84, + "u" : 85, + "v" : 86, + "w" : 87, + "x" : 88, + "y" : 89, + "z" : 90 }; + +SHORTCUTS = ["1", "2", "3", "5", "6", "7", "8", "9", "O", "a", "b", "c", "d", "e", "f", "g", "h", "i", + "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"]; + +function bindKey(key, handler) { + $(document).keydown(function(event) { + if (event.which == KEYS[key]) { + handler(); + } + }) + +} + +function redirectTo(a) { + window.location = a.attr('href'); +} + function processTemplate(templateId, model) { var processing = $('#' + templateId).clone().children(); var elementsWithData = $(processing).find('*[data]'); Modified: trunk/magalie-web/src/main/webapp/js/receive-article-input.js =================================================================== --- trunk/magalie-web/src/main/webapp/js/receive-article-input.js 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/js/receive-article-input.js 2013-05-22 07:02:15 UTC (rev 174) @@ -242,6 +242,6 @@ $('#receive-article').submit(controller.onSubmit); $('#receive-article_full').click(controller.onReportError); $('#receive-article_next').click(controller.onNext); - + bindKey('F5', controller.onReportError); view.refresh(); }); Modified: trunk/magalie-web/src/main/webapp/js/withdraw-item-input.js =================================================================== --- trunk/magalie-web/src/main/webapp/js/withdraw-item-input.js 2013-05-21 15:20:38 UTC (rev 173) +++ trunk/magalie-web/src/main/webapp/js/withdraw-item-input.js 2013-05-22 07:02:15 UTC (rev 174) @@ -270,6 +270,6 @@ $('#withdraw-item').submit(controller.onSubmit); $('#reportError').click(controller.onReportError); $('#withdraw-item_next').click(controller.onNext); - + bindKey('F5', controller.onReportError); view.refresh(); });

1 0

r173 - trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service
by bleny＠users.forge.codelutin.com 21 May '13

21 May '13

Author: bleny Date: 2013-05-21 17:20:38 +0200 (Tue, 21 May 2013) New Revision: 173 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2167 introduce PreparedReceptionService Added: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/PreparedReceptionService.java Added: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/PreparedReceptionService.java =================================================================== --- trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/PreparedReceptionService.java (rev 0) +++ trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/PreparedReceptionService.java 2013-05-21 15:20:38 UTC (rev 173) @@ -0,0 +1,25 @@ +package com.franciaflex.magalie.services.service; + +import com.franciaflex.magalie.services.MagalieServiceContext; + +public class PreparedReceptionService { + + protected MagalieServiceContext serviceContext; + + public void setServiceContext(MagalieServiceContext serviceContext) { + this.serviceContext = serviceContext; + } + + public void findLocationsToReceiveArticle(String preparedReceptionBarcode) { + + ReceptionService receptionService = + serviceContext.newService(ReceptionService.class); + +// List<Location> locations = +// receptionService.findLocationsToReceiveArticle(); + + + + } + +}

1 0

r172 - trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service
by bleny＠users.forge.codelutin.com 21 May '13

21 May '13

Author: bleny Date: 2013-05-21 15:16:47 +0200 (Tue, 21 May 2013) New Revision: 172 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2165 suggest locations of the same warehouse first Modified: trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java Modified: trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java =================================================================== --- trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java 2013-05-21 13:12:25 UTC (rev 171) +++ trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java 2013-05-21 13:16:47 UTC (rev 172) @@ -117,11 +117,11 @@ List<StoredArticle> receivedArticles = service.getReceivedArticles(building, supplier.getId()); - StoredArticle onlyElement = + StoredArticle receivedArticle = Iterables.getOnlyElement(receivedArticles); ReceptionTask receptionTask = - service.getReceptionTask(onlyElement.getId()); + service.getReceptionTask(receivedArticle.getId()); Location fixedLocation = Iterables.getOnlyElement(article.getFixedLocations()); @@ -129,18 +129,18 @@ Assert.assertEquals(fixedLocation, receptionTask.getLocations().get(0)); // locations of the same warehouse - Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(1).getWarehouse()); - Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(2).getWarehouse()); - Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(3).getWarehouse()); + Assert.assertEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(1).getWarehouse()); + Assert.assertEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(2).getWarehouse()); + Assert.assertEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(3).getWarehouse()); // locations in another warehouse last - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(4).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(5).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(6).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(7).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(8).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(9).getWarehouse()); - Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(10).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(4).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(5).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(6).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(7).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(8).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(9).getWarehouse()); + Assert.assertNotEquals(receivedArticle.getLocation().getWarehouse(), receptionTask.getLocations().get(10).getWarehouse()); for (Location location : receptionTask.getLocations()) {

1 0

r171 - in trunk: magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/jpa magalie-services/src/main/java/com/franciaflex/magalie/services/service magalie-services/src/test/java/com/franciaflex/magalie/services/service
by bleny＠users.forge.codelutin.com 21 May '13

21 May '13

Author: bleny Date: 2013-05-21 15:12:25 +0200 (Tue, 21 May 2013) New Revision: 171 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revision… Log: refs #2165 suggest locations of the same warehouse first Modified: trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/LocationDao.java trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/jpa/LocationJpaDao.java trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/ReceptionService.java trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java Modified: trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/LocationDao.java =================================================================== --- trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/LocationDao.java 2013-05-21 10:28:31 UTC (rev 170) +++ trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/LocationDao.java 2013-05-21 13:12:25 UTC (rev 171) @@ -35,4 +35,5 @@ List<Location> findAllWithoutReception(Building building); + List<Location> findAllWithoutReception(Warehouse warehouse); } Modified: trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/jpa/LocationJpaDao.java =================================================================== --- trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/jpa/LocationJpaDao.java 2013-05-21 10:28:31 UTC (rev 170) +++ trunk/magalie-persistence/src/main/java/com/franciaflex/magalie/persistence/dao/jpa/LocationJpaDao.java 2013-05-21 13:12:25 UTC (rev 171) @@ -52,18 +52,39 @@ return findUnique(query); } - @Override - public List<Location> findAllWithoutReception(Building building) { - TypedQuery<Location> query = createQuery( - " from Location l where" - + " l.warehouse.building = :building and " - + " l.code != :codeForReceptionLocations and " - + " l.code != :codeForWarehouseWithoutLocations and " - + " l.fullLocation = false " - + " order by l.warehouse.building.code, l.warehouse.code, l.code"); - query.setParameter("building", building); + protected List<Location> findAllWithoutReception(Building building, Warehouse warehouse) { + boolean filterOnBuilding = building != null; + boolean filterOnWarehouse = warehouse != null; + String hql = " from Location l where"; + if (filterOnBuilding) { + hql += " l.warehouse.building = :building and "; + } + if (filterOnWarehouse) { + hql += " l.warehouse = :warehouse and "; + } + hql += " l.code != :codeForReceptionLocations and " + + " l.code != :codeForWarehouseWithoutLocations and " + + " l.fullLocation = false " + + " order by l.warehouse.building.code, l.warehouse.code, l.code"; + TypedQuery <Location> query = createQuery(hql); + if (filterOnBuilding) { + query.setParameter("building", building); + } + if (filterOnWarehouse) { + query.setParameter("warehouse", warehouse); + } query.setParameter("codeForReceptionLocations", Locations.codeForReceptionLocations()); query.setParameter("codeForWarehouseWithoutLocations", Locations.codeForWarehouseWithoutLocations()); return findAll(query); } + + @Override + public List<Location> findAllWithoutReception(Building building) { + return findAllWithoutReception(building, null); + } + + @Override + public List<Location> findAllWithoutReception(Warehouse warehouse) { + return findAllWithoutReception(null, warehouse); + } } Modified: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/ReceptionService.java =================================================================== --- trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/ReceptionService.java 2013-05-21 10:28:31 UTC (rev 170) +++ trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/ReceptionService.java 2013-05-21 13:12:25 UTC (rev 171) @@ -37,6 +37,7 @@ import com.franciaflex.magalie.persistence.entity.StorageMovement; import com.franciaflex.magalie.persistence.entity.StoredArticle; import com.franciaflex.magalie.persistence.entity.Supplier; +import com.franciaflex.magalie.persistence.entity.Warehouse; import com.franciaflex.magalie.services.MagalieService; import com.franciaflex.magalie.services.MagalieServiceContext; import com.google.common.collect.Iterables; @@ -152,9 +153,9 @@ Article article = storedArticle.getArticle(); - Building building = storedArticle.getLocation().getWarehouse().getBuilding(); + Warehouse warehouse = storedArticle.getLocation().getWarehouse(); - List<Location> locations = findLocationsToReceiveArticle(building, article); + List<Location> locations = findLocationsToReceiveArticle(warehouse, article); ReceptionTask receptionTask = new ReceptionTask(storedArticle, locations); @@ -162,7 +163,7 @@ } - protected List<Location> findLocationsToReceiveArticle(Building building, Article article) { + protected List<Location> findLocationsToReceiveArticle(Warehouse warehouse, Article article) { // first step, add fixed locations for this article first Set<Location> locations = Sets.newLinkedHashSet(); @@ -179,7 +180,7 @@ serviceContext.newService(ArticleStorageService.class); Iterable<StoredArticle> storedArticles = - articleStorageService.getStoredArticles(building, article); + articleStorageService.getStoredArticles(warehouse.getBuilding(), article); Ordering<StoredArticle> comparator = Ordering.compound( Lists.newArrayList( @@ -204,8 +205,12 @@ LocationDao locationDao = persistenceContext.getLocationDao(); - locations.addAll(locationDao.findAllWithoutReception(building)); + // add all locations in the same warehouse + locations.addAll(locationDao.findAllWithoutReception(warehouse)); + // add all locations in the same building, other warehouses + locations.addAll(locationDao.findAllWithoutReception(warehouse.getBuilding())); + // fourth step, remove reception locations because it's stupid to // move an article from reception location to another reception location // also, remove full locations Modified: trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java =================================================================== --- trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java 2013-05-21 10:28:31 UTC (rev 170) +++ trunk/magalie-services/src/test/java/com/franciaflex/magalie/services/service/ReceptionServiceTest.java 2013-05-21 13:12:25 UTC (rev 171) @@ -125,8 +125,23 @@ Location fixedLocation = Iterables.getOnlyElement(article.getFixedLocations()); + // fixed location Assert.assertEquals(fixedLocation, receptionTask.getLocations().get(0)); + // locations of the same warehouse + Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(1).getWarehouse()); + Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(2).getWarehouse()); + Assert.assertEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(3).getWarehouse()); + + // locations in another warehouse last + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(4).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(5).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(6).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(7).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(8).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(9).getWarehouse()); + Assert.assertNotEquals(onlyElement.getLocation().getWarehouse(), receptionTask.getLocations().get(10).getWarehouse()); + for (Location location : receptionTask.getLocations()) { if (log.isDebugEnabled()) { @@ -147,6 +162,12 @@ "we should never suggest someone to store something in a full location", location.isFullLocation()); + Assert.assertEquals( + "we shoud only suggest locations in the same building", + building, + location.getWarehouse().getBuilding() + ); + } }

1 0

Jenkins build became unstable: franciaflex-magalie #46
by admin+hudson＠codelutin.com 21 May '13

21 May '13

See <http://ci.nuiton.org/jenkins/job/franciaflex-magalie/46/changes>

1 1

Jenkins build became unstable: franciaflex-magalie » MagaLiE :: Services #46
by admin+hudson＠codelutin.com 21 May '13

21 May '13

See <http://ci.nuiton.org/jenkins/job/franciaflex-magalie/com.franciaflex$magali…>

1 1