- Observe-commits - mailman.cloud.codelutin.com

[Git][ultreiaio/ird-observe] Deleted branch feature/issue_2959
by Tony CHEMIT (＠tchemit) 11 Dec '24

11 Dec '24

Tony CHEMIT deleted branch feature/issue_2959 at ultreiaio / ird-observe -- You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][feature/issue_2959] Update tests fixtures
by Tony CHEMIT (＠tchemit) 11 Dec '24

11 Dec '24

Tony CHEMIT pushed to branch feature/issue_2959 at ultreiaio / ird-observe Commits: 2bca2b11 by Tony Chemit at 2024-12-11T11:43:57+01:00 Update tests fixtures - - - - - 3 changed files: - core/persistence/test/src/test/resources/fixtures/persistence/table_count/referential.properties - core/services/test/src/main/resources/fixtures/fr/ird/observe/services/service/ValidateService-referentialResult-ps-default.json - model/src/main/resources/fixtures/global.properties Changes: ===================================== core/persistence/test/src/test/resources/fixtures/persistence/table_count/referential.properties ===================================== @@ -95,7 +95,7 @@ ps_common.transmittingBuoyType=62 ps_common.vesselActivity=39 ps_common.weightCategory=137 ps_landing.destination=30 -ps_landing.fate=2 +ps_landing.fate=4 ps_localmarket.batchComposition=3 ps_localmarket.batchWeightType=4 ps_localmarket.packaging=53 ===================================== core/services/test/src/main/resources/fixtures/fr/ird/observe/services/service/ValidateService-referentialResult-ps-default.json ===================================== @@ -13483,6 +13483,38 @@ } ] }, + { + "datum": { + "text": "3##Vendu sur le marché local", + "type": "fr.ird.observe.dto.referential.ps.landing.FateDto", + "id": "fr.ird.referential.ps.landing.Fate#1714114980513#0.3095970028802679", + "topiaVersion": 0, + "lastUpdateDate": "2024-04-26T11:03:00.513Z" + }, + "messages": [ + { + "fieldName": "uri", + "scope": "WARNING", + "message": "Le champ n'est pas renseigné." + } + ] + }, + { + "datum": { + "text": "4##Transbordé (conteneur ou cargo)", + "type": "fr.ird.observe.dto.referential.ps.landing.FateDto", + "id": "fr.ird.referential.ps.landing.Fate#1714115075625#0.4347800278392995", + "topiaVersion": 0, + "lastUpdateDate": "2024-04-26T11:04:35.625Z" + }, + "messages": [ + { + "fieldName": "uri", + "scope": "WARNING", + "message": "Le champ n'est pas renseigné." + } + ] + }, { "datum": { "text": "1##Multi spécifique (sondage)", ===================================== model/src/main/resources/fixtures/global.properties ===================================== @@ -25,4 +25,4 @@ REFERENCE_DATA_COUNT=68 ENTITIES_LIMIT_SIZE=100 # fr.ird.observe.services.service.referential.ReferentialService # fr.ird.observe.services.local.service.referential.DifferentialModelTest -REFERENTIAL_COUNT=4391 +REFERENTIAL_COUNT=4393 View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/2bca2b11d357233f4fcf2b97d… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/2bca2b11d357233f4fcf2b97d… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][feature/issue_2959] 3 commits: Review import code for Landing.fate field
by Tony CHEMIT (＠tchemit) 11 Dec '24

11 Dec '24

Tony CHEMIT pushed to branch feature/issue_2959 at ultreiaio / ird-observe Commits: daaf003d by Tony Chemit at 2024-12-11T11:23:11+01:00 Review import code for Landing.fate field - - - - - 0c74c297 by Tony Chemit at 2024-12-11T11:23:11+01:00 Update AVDTH documentation - - - - - 0c44ebc6 by Tony Chemit at 2024-12-11T11:23:11+01:00 Add by migration ps_landing.Fate 3 and 4 if necessary - - - - - 7 changed files: - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportReferentialContext.java - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/common/LandingReader.java - core/persistence/migration/src/main/java/fr/ird/observe/spi/migration/v9/DataSourceMigrationForVersion_9_4.java - + core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_3-common.sql - + core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_4-common.sql - + core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_finalize-common.sql - src/site/markdown/avdth/landing.md Changes: ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportReferentialContext.java ===================================== @@ -69,7 +69,6 @@ import java.util.List; import java.util.Map; import java.util.Objects; import java.util.TreeMap; -import java.util.function.Consumer; /** * Contains all referential used in import and all the logic of them. @@ -113,8 +112,10 @@ public class ImportReferentialContext { private SizeMeasureType sizeMeasureTypeDL; private DataQuality dataQualityA; private DataQuality dataQualityE; - private Fate fate1; - private Fate fate2; + private Fate fateProcessed; + private Fate fateDiscarded; + private Fate fateSoldOnLocalMarket; + private Fate fateTransshipment; private AcquisitionStatus acquisitionStatus1; private AcquisitionStatus acquisitionStatus999; private TransmittingBuoyType transmittingBuoyType98; @@ -185,8 +186,10 @@ public class ImportReferentialContext { landingCategories = Maps.uniqueIndex(referential.getWeightCategory(), WeightCategory::getCode); Map<String, Fate> fates = Maps.uniqueIndex(referential.getFate(), Fate::getCode); - fate1 = fates.get("1"); - fate2 = fates.get("2"); + fateProcessed = fates.get("1"); + fateDiscarded = fates.get("2"); + fateSoldOnLocalMarket = fates.get("3"); + fateTransshipment = fates.get("4"); destinations = Maps.uniqueIndex(referential.getDestination(), Destination::getCode); @@ -388,8 +391,12 @@ public class ImportReferentialContext { return schoolType2; } + public boolean isSpeciesDiscarded(String speciesCode) { + return speciesCode.equals("8") || (speciesCode.startsWith("8") && speciesCode.length() == 3); + } + public SpeciesFate getSpeciesFate(String speciesCode) { - if (speciesCode.equals("8") || (speciesCode.startsWith("8") && speciesCode.length() == 3)) { + if (isSpeciesDiscarded(speciesCode)) { // all species in avdth with code 8 or 8xx are discard return speciesFate11; } @@ -453,12 +460,20 @@ public class ImportReferentialContext { return transmittingBuoyOperation1; } - public Fate getFateBySpeciesCode(String originalSpeciesCode) { - // fate 1 if not discarded, 2 discarded (only for species 8) - if (originalSpeciesCode.equals("8")) { - return fate2; - } - return fate1; + public Fate getFateProcessed() { + return fateProcessed; + } + + public Fate getFateDiscarded() { + return fateDiscarded; + } + + public Fate getFateSoldOnLocalMarket() { + return fateSoldOnLocalMarket; + } + + public Fate getFateTransshipment() { + return fateTransshipment; } public Harbour getHarbour(String code) { ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/common/LandingReader.java ===================================== @@ -27,6 +27,7 @@ import fr.ird.observe.entities.data.ps.landing.Landing; import fr.ird.observe.entities.referential.common.Species; import fr.ird.observe.entities.referential.ps.common.WeightCategory; import fr.ird.observe.entities.referential.ps.landing.Destination; +import fr.ird.observe.entities.referential.ps.landing.Fate; import fr.ird.observe.persistence.avdth.data.DataQueryDefinition; import fr.ird.observe.persistence.avdth.data.DataReader; import fr.ird.observe.persistence.avdth.data.ImportDataContext; @@ -106,8 +107,34 @@ public class LandingReader extends DataReader<Landing> { String destinationCode = resultSet.getString(7); Destination destination = dataContext.getDestination(destinationCode); entity.setDestination(destination); - entity.setFate(dataContext.getFateBySpeciesCode(originalSpeciesCode)); + Fate fate = getFate(dataContext, originalSpeciesCode, destinationCode); + entity.setFate(fate); return entity; } + + private Fate getFate(ImportDataContext dataContext, String originalSpeciesCode, String avdthDestinationCode) { + if (avdthDestinationCode != null) { + int code = Integer.parseInt(avdthDestinationCode); + if (isDestinationCodeToTransshipment(code)) { + return dataContext.getFateTransshipment(); + } + if (isDestinationCodeToSoldOnLocalMarket(code)) { + return dataContext.getFateSoldOnLocalMarket(); + } + } + if (dataContext.isSpeciesDiscarded(originalSpeciesCode)) { + return dataContext.getFateDiscarded(); + } + return dataContext.getFateProcessed(); + } + + private boolean isDestinationCodeToTransshipment(int code) { + return code == 3 || code == 4; + } + + private boolean isDestinationCodeToSoldOnLocalMarket(int code) { + return code == 18 || code == 28 || (code >= 40 && code <= 61) || (code >= 64 && code <= 65); + } + } ===================================== core/persistence/migration/src/main/java/fr/ird/observe/spi/migration/v9/DataSourceMigrationForVersion_9_4.java ===================================== @@ -34,6 +34,9 @@ import java.math.BigDecimal; import java.math.RoundingMode; import java.sql.ResultSet; import java.sql.SQLException; +import java.util.LinkedHashSet; +import java.util.Set; +import java.util.stream.Stream; /** * Created at 11/09/2024. @@ -66,6 +69,8 @@ public class DataSourceMigrationForVersion_9_4 extends ByMajorMigrationVersionRe issue2669(executor); // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2932 issue2932(executor,withIds); + // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2959 + issue2959(executor,withIds); } private void issue2914(MigrationVersionResourceExecutor executor) { @@ -104,6 +109,23 @@ public class DataSourceMigrationForVersion_9_4 extends ByMajorMigrationVersionRe executor.addScript("05_06", "issue-2932_update-table-ll-observation-weight-measure"); } + + private void issue2959(MigrationVersionResourceExecutor executor, boolean withIds) { + if (withIds) { + Set<String> existingCodes = executor.findMultipleResultAstSet(SqlQuery.wrap("SELECT CODE FROM ps_landing.Fate", resultSet -> resultSet.getString(1))); + Set<String> newCodes = new LinkedHashSet<>(); + Stream.of("3", "4").forEach(code -> { + if (!existingCodes.contains(code)) { + executor.addScript("06_issue-2959_add_referential_ps_landing_Fate", code); + newCodes.add(code); + } + }); + if (!newCodes.isEmpty()) { + executor.addScript("06_issue-2959_add_referential_ps_landing_Fate", "finalize"); + } + } + } + private static class BasketRecord { private final String id; private final Float floatline1Length; ===================================== core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_3-common.sql ===================================== @@ -0,0 +1,22 @@ +--- +-- #%L +-- ObServe Core :: Persistence :: Migration +-- %% +-- Copyright (C) 2008 - 2024 IRD, Ultreia.io +-- %% +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as +-- published by the Free Software Foundation, either version 3 of the +-- License, or (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public +-- License along with this program. If not, see +-- <http://www.gnu.org/licenses/gpl-3.0.html>. +-- #L% +--- +INSERT INTO ps_landing.Fate(topiaid, topiaversion, topiacreatedate, lastUpdateDate, needComment, status, code, label1, label2, label3, discard) VALUES ('fr.ird.referential.ps.landing.Fate#1714114980513#0.3095970028802679', 0, '2024-04-26T09:00:41.215Z'::timestamp, '2024-04-26T09:03:00.513Z'::timestamp, FALSE, 1, '3' , 'Sold for local market', 'Vendu sur le marché local', 'Vendido en el mercado local', false); ===================================== core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_4-common.sql ===================================== @@ -0,0 +1,22 @@ +--- +-- #%L +-- ObServe Core :: Persistence :: Migration +-- %% +-- Copyright (C) 2008 - 2024 IRD, Ultreia.io +-- %% +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as +-- published by the Free Software Foundation, either version 3 of the +-- License, or (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public +-- License along with this program. If not, see +-- <http://www.gnu.org/licenses/gpl-3.0.html>. +-- #L% +--- +INSERT INTO ps_landing.Fate(topiaid, topiaversion, topiacreatedate, lastUpdateDate, needComment, status, code, label1, label2, label3, discard) VALUES ('fr.ird.referential.ps.landing.Fate#1714115075625#0.4347800278392995', 0, '2024-04-26T09:03:12.339Z'::timestamp, '2024-04-26T09:04:35.625Z'::timestamp, FALSE, 1, '4' , 'Transshipment (container or cargo)', 'Transbordé (conteneur ou cargo)', 'Transbordo (contenedor o carga)', false); ===================================== core/persistence/migration/src/main/resources/db/migration/v9/9.4/06_issue-2959_add_referential_ps_landing_Fate_finalize-common.sql ===================================== @@ -0,0 +1,22 @@ +--- +-- #%L +-- ObServe Core :: Persistence :: Migration +-- %% +-- Copyright (C) 2008 - 2024 IRD, Ultreia.io +-- %% +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as +-- published by the Free Software Foundation, either version 3 of the +-- License, or (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public +-- License along with this program. If not, see +-- <http://www.gnu.org/licenses/gpl-3.0.html>. +-- #L% +--- +UPDATE common.LastUpdateDate SET lastUpdateDate = ${CURRENT_TIMESTAMP} WHERE type ='fr.ird.observe.entities.referential.ps.landing.Fate'; ===================================== src/site/markdown/avdth/landing.md ===================================== @@ -14,7 +14,7 @@ Table déversée dans la table d'ObServe **Landing**. | LOT_COM_04 | C_ESP | Landing.species | [2](#n_0_2), [5](#n_0_5) | | LOT_COM_05 | C_CAT_C | Landing.weightCategory | [3](#n_0_3) | | LOT_COM_06 | V_POIDS_LC | Landing.weight | | -| LOT_COM_07 | C_DEST | Landing.destination | [4](#n_0_4) | +| LOT_COM_07 | C_DEST | Landing.destination | [4](#n_0_4), [5](#n_0_5) | * Note 1 <a name="n_0_1"></a> @@ -34,8 +34,15 @@ Mapping direct sur le code du référentiel **ps_landing.Destination**. * Note 5 <a name="n_0_5"></a> -On positionne **ps_landing.Landing.fate** à partir du code suivant +On positionne **ps_landing.Landing.fate** en suivant ce code -```ps_landing.Fate(LOT_COM.C_ESP == 8 ? 2 : 1)``` +**FIXME Voir https://gitlab.com/ultreiaio/ird-observe/-/issues/2959 ** + +On distingue quatre cas : + +1. Si LOT_COM.C_DEST dans ```4 ou 5``` alors on utilise ps_landing.Fate de code 4 (transbordement) +2. Si LOT_COM.C_DEST dans ```18, 28, 40 à 61, 64 à 65)``` alors on utilise ps_landing.Fate de code 3 (vendu au marché local) +2. Sinon si LOT_COM.C_ESP est dans ```8, 800 à 899``` alors on utilise ps_landing.Fate de code 2 (rejeté) +3. Sinon on utilise ps_landing.Fate de code 1 (traité) [Retour à l'introduction](./index.html) View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/9bc1160aed3074cbdf48383c… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/9bc1160aed3074cbdf48383c… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][feature/issue_2959] Update AVDTH documentation
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch feature/issue_2959 at ultreiaio / ird-observe Commits: 9bc1160a by Tony Chemit at 2024-12-10T20:47:04+01:00 Update AVDTH documentation - - - - - 1 changed file: - src/site/markdown/avdth/landing.md Changes: ===================================== src/site/markdown/avdth/landing.md ===================================== @@ -14,7 +14,7 @@ Table déversée dans la table d'ObServe **Landing**. | LOT_COM_04 | C_ESP | Landing.species | [2](#n_0_2), [5](#n_0_5) | | LOT_COM_05 | C_CAT_C | Landing.weightCategory | [3](#n_0_3) | | LOT_COM_06 | V_POIDS_LC | Landing.weight | | -| LOT_COM_07 | C_DEST | Landing.destination | [4](#n_0_4) | +| LOT_COM_07 | C_DEST | Landing.destination | [4](#n_0_4), [5](#n_0_5) | * Note 1 <a name="n_0_1"></a> @@ -34,8 +34,15 @@ Mapping direct sur le code du référentiel **ps_landing.Destination**. * Note 5 <a name="n_0_5"></a> -On positionne **ps_landing.Landing.fate** à partir du code suivant +On positionne **ps_landing.Landing.fate** en suivant ce code -```ps_landing.Fate(LOT_COM.C_ESP == 8 ? 2 : 1)``` +**FIXME Voir https://gitlab.com/ultreiaio/ird-observe/-/issues/2959 ** + +On distingue quatre cas : + +1. Si LOT_COM.C_DEST dans ```4 ou 5``` alors on utilise ps_landing.Fate de code 4 (transbordement) +2. Si LOT_COM.C_DEST dans ```18, 28, 40 à 61, 64 à 65)``` alors on utilise ps_landing.Fate de code 3 (vendu au marché local) +2. Sinon si LOT_COM.C_ESP est dans ```8, 800 à 899``` alors on utilise ps_landing.Fate de code 2 (rejeté) +3. Sinon on utilise ps_landing.Fate de code 1 (traité) [Retour à l'introduction](./index.html) View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/9bc1160aed3074cbdf48383c0… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/9bc1160aed3074cbdf48383c0… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe] Pushed new branch feature/issue_2959
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed new branch feature/issue_2959 at ultreiaio / ird-observe -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/tree/feature/issue_2959 You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][develop] 5 commits: Rename ImportDataContext.observedSystemCodes to ImportDataContext.avdthObservedSystemCodes
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: 0029ceac by Tony Chemit at 2024-12-10T19:27:42+01:00 Rename ImportDataContext.observedSystemCodes to ImportDataContext.avdthObservedSystemCodes - - - - - 6cf171ff by Tony Chemit at 2024-12-10T19:27:59+01:00 Clean ImportDataContext.avdthObservedSystemCodes at a better place and no more in FloatingObjectReader.resetContext method (which is removed) - - - - - 18425465 by Tony Chemit at 2024-12-10T19:27:59+01:00 Clean code - - - - - 70cf3133 by Tony Chemit at 2024-12-10T19:38:17+01:00 Now just clean the method to add observed system 20 if required from avdth observed system code found - - - - - 2fd99075 by Tony Chemit at 2024-12-10T19:44:09+01:00 Merge branch 'feature/issue_2961' into develop 2 mappings AVDTH ASSOC non fonctionnels - Closes #2961 - - - - - 4 changed files: - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportDataContext.java - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportEngineExecution.java - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/logbook/ActivityReader.java - core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/logbook/FloatingObjectReader.java Changes: ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportDataContext.java ===================================== @@ -28,7 +28,6 @@ import fr.ird.observe.entities.data.ps.logbook.Route; import fr.ird.observe.entities.referential.ps.common.ObservedSystem; import fr.ird.observe.persistence.avdth.data.logbook.FloatingObjectReader; -import java.util.Iterator; import java.util.LinkedHashSet; import java.util.Map; import java.util.Set; @@ -50,7 +49,12 @@ public class ImportDataContext extends ImportReferentialContext { private Trip trip; private Route route; private Activity activity; - private Set<String> observedSystemCodes; + /** + * Collected avdth observed system code from the ACT_ASSOC. + * + * @see fr.ird.observe.persistence.avdth.data.logbook.ActivityReader.ActivityObservedSystemTableReader + */ + private Set<String> avdthObservedSystemCodes; private boolean canCreateActivity; public boolean isCanCreateActivity() { @@ -96,50 +100,42 @@ public class ImportDataContext extends ImportReferentialContext { return activityPkToId; } - public Set<String> getObservedSystemCodes() { - return observedSystemCodes; + public Set<String> getAvdthObservedSystemCodes() { + return avdthObservedSystemCodes; } public Set<ObservedSystem> getObservedSystems() { return observedSystems; } - public void setObservedSystemCodes(Set<String> observedSystemCodes) { - this.observedSystemCodes = observedSystemCodes; + public void setAvdthObservedSystemCodes(Set<String> avdthObservedSystemCodes) { + this.avdthObservedSystemCodes = avdthObservedSystemCodes; } public void addDefaultObservedSystemOrSanitizeFloatingObjectOnes(Activity entity) { - if (entity.isObservedSystemEmpty()) { - // add no observed system - entity.addObservedSystem(getObservedSystem0()); - } else { - // Remove any observed system from code 21 to 25, and at last if one of them has been found - // add (if not already present the observed system 20, this case should never happen, but just in case...) - // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2548 - boolean observedSystemsToRemoveFound = false; - boolean observedSystem20Found = false; - - Set<ObservedSystem> observedSystems = entity.getObservedSystem(); - Iterator<ObservedSystem> iterator = observedSystems.iterator(); + // Remove any observed system from code 21 to 25, and at last if one of them has been found + // add (if not already present the observed system 20, this case should never happen, but just in case...) + // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2548 + // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2961 - while (iterator.hasNext()) { - ObservedSystem observedSystem = iterator.next(); - if (FloatingObjectReader.OBSERVED_SYTEM_CODES_TO_REMOVE.contains(observedSystem.getCode())) { - // remove this one - iterator.remove(); - observedSystemsToRemoveFound = true; - continue; - } + boolean floatingObjectCreatedByObservedSystem = avdthObservedSystemCodes.stream().anyMatch(FloatingObjectReader.OBSERVED_SYTEM_CODES_WITH_DCP::contains); + if (floatingObjectCreatedByObservedSystem) { + boolean observedSystem20Found = false; + for (ObservedSystem observedSystem : entity.getObservedSystem()) { if ("20".equals(observedSystem.getCode())) { observedSystem20Found = true; } } - if (observedSystemsToRemoveFound && !observedSystem20Found) { - // add the Observed system 20 (This cas should never happen, but I can not afford to check it now...) - ObservedSystem observedSystem20 = getObservedSystem20(); - observedSystems.add(observedSystem20); + if (!observedSystem20Found) { + // add the Observed system 20 + entity.addObservedSystem(getObservedSystem20()); + return; } } + if (entity.isObservedSystemEmpty()) { + // add no observed system + entity.addObservedSystem(getObservedSystem0()); + } } public void computeCanCreateActivity() { ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/ImportEngineExecution.java ===================================== @@ -157,7 +157,7 @@ public class ImportEngineExecution extends ImportEngine { // load observed systems for this activity Set<String> observedSystemCodes = activityReader.readObservedSystem(context, tables.activityObservedSystemTableReader, ActivityReader.getActivityPk(activityRow)); - context.setObservedSystemCodes(observedSystemCodes); + context.setAvdthObservedSystemCodes(observedSystemCodes); // load activity Activity activity = activityWriter.intercept(activityRow, routeId, 0); @@ -176,6 +176,8 @@ public class ImportEngineExecution extends ImportEngine { // add default observed system (if none found) and sanitize some observed system coming from DCP context.addDefaultObservedSystemOrSanitizeFloatingObjectOnes(activity); + // clean this data context state + context.setAvdthObservedSystemCodes(null); // write activity observed systems activityWriter.writeObservedSystems(activity); // while loading Floating objects, we may have change the vessel activity of the activity ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/logbook/ActivityReader.java ===================================== @@ -361,10 +361,10 @@ public class ActivityReader extends DataReader<Activity> { ResultSet activityObservedSystemRow = activityObservedSystemTableReader.next(); String avdthSystemCode = activityObservedSystemRow.getString(6); observedSystemCodes.add(avdthSystemCode); - if (!ObservedSystemInterceptor.CODE_MAPPING.containsKey(avdthSystemCode)) { + String observeSystemCode = ObservedSystemInterceptor.CODE_MAPPING.get(avdthSystemCode); + if (observeSystemCode == null) { throw new IllegalStateException(String.format("Can't find observedSystem with code: %s from ad-hoc AVDTH to ObServe mapping", avdthSystemCode)); } - String observeSystemCode = ObservedSystemInterceptor.CODE_MAPPING.get(avdthSystemCode); ObservedSystem observedSystem = dataContext.getObservedSystem(observeSystemCode); observedSystems.add(observedSystem); } ===================================== core/persistence/avdth/src/main/java/fr/ird/observe/persistence/avdth/data/logbook/FloatingObjectReader.java ===================================== @@ -208,11 +208,7 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { * Observed system from {@code ACT_ASSOC} which can create a Floating object. */ public static final Set<String> OBSERVED_SYTEM_CODES_WITH_DCP = Set.of("20", "21", "22", "23", "24", "25", "81"); - /** - * We need to remove thoses observed system at the end when writing them to activity. - * See <a href="https://gitlab.com/ultreiaio/ird-observe/-/issues/2548">issue 2548</a> - */ - public static final Set<String> OBSERVED_SYTEM_CODES_TO_REMOVE = Set.of("21", "22", "23", "24", "25"); + private final MutableInt floatingObjectPartCount = new MutableInt(); private final MutableInt transmittingBuoyCount = new MutableInt(); @@ -232,13 +228,13 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { VesselActivity vesselActivity = activity.getVesselActivity(); // Avdth observed system codes associated to the current activity (need them to compute ex nihilo floating object) - Set<String> observedSystemCodes = dataContext.getObservedSystemCodes(); + Set<String> avdthObservedSystemCodes = dataContext.getAvdthObservedSystemCodes(); // We need to get the original vessel activity code from AVDTH (to compute some mapping) String vesselActivityCode = resultSet.getString(13); // Is the floating object can be created by the observed systems? - boolean floatingObjectCreatedByObservedSystem = observedSystemCodes.stream().anyMatch(OBSERVED_SYTEM_CODES_WITH_DCP::contains); + boolean floatingObjectCreatedByObservedSystem = avdthObservedSystemCodes.stream().anyMatch(OBSERVED_SYTEM_CODES_WITH_DCP::contains); // Is the current vessel activity accept to create Floating object? boolean vesselActivityAllowFad = vesselActivity.isAllowFad(); @@ -266,7 +262,6 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { // neither the buoy exist in avdth, // neither need to be created by observed system, // Do not create the floating object (no log is required here: we are on an activity with no floating object) - reset(dataContext); return null; } @@ -296,7 +291,6 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { } // do not create the floating object - reset(dataContext); return null; } @@ -323,16 +317,11 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { if (observedSystem != null) { activity.addObservedSystem(observedSystem); } - // See https://gitlab.com/ultreiaio/ird-observe/-/issues/2802 - if (observedSystemCodes.contains("81")) { - activity.addObservedSystem(dataContext.getObservedSystem20()); - } - boolean addBuoyFromObservedSystem = addFloatingObjectMaterials(dataContext, resultSet, vesselActivityCode, objectTypeCode, - observedSystemCodes, + avdthObservedSystemCodes, objectOperation, entity, floatingObjectExistsInAvdth, @@ -348,7 +337,6 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { // only add buoy if buoy type known entity.addTransmittingBuoy(transmittingBuoy); } - reset(dataContext); return entity; } @@ -356,7 +344,7 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { ResultSet resultSet, String vesselActivityCode, String objectTypeCode, - Set<String> observedSystemCodes, + Set<String> avdthObservedSystemCodes, ObjectOperation objectOperation, FloatingObject entity, boolean floatingObjectExistsInAvdth, @@ -379,40 +367,40 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { } } - if (observedSystemCodes.contains("20")) { + if (avdthObservedSystemCodes.contains("20")) { // add ObjectMaterial FOB addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialFOB(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; } - if (observedSystemCodes.contains("21")) { + if (avdthObservedSystemCodes.contains("21")) { // add ObjectMaterial 2-1-1 VNLOG addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialVNLOG(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; } - if (observedSystemCodes.contains("22")) { + if (avdthObservedSystemCodes.contains("22")) { // add ObjectMaterial 2-1-1 VNLOG + 1-1 DFAD addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialVNLOG(), whenArriving, whenLeaving, entity); addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialDFAD(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; addBuoyFromObservedSystem = true; } - if (observedSystemCodes.contains("23")) { + if (avdthObservedSystemCodes.contains("23")) { // add ObjectMaterial 2-2 ALOG addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialALOG(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; } - if (observedSystemCodes.contains("24")) { + if (avdthObservedSystemCodes.contains("24")) { // add ObjectMaterial 1-1 DFAD addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialDFAD(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; addBuoyFromObservedSystem = true; } - if (observedSystemCodes.contains("25")) { + if (avdthObservedSystemCodes.contains("25")) { // add ObjectMaterial 1-2 AFAD addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialAFAD(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; } - if (observedSystemCodes.contains("81")) { + if (avdthObservedSystemCodes.contains("81")) { // add ObjectMaterial 2-1-2-1 Carrion addObjectMaterial(vesselActivityCode, objectMaterialUsed, dataContext.getObjectMaterialCarrion(), whenArriving, whenLeaving, entity); addDefaultObjectMaterialOnUnknownObjectType = false; @@ -475,11 +463,6 @@ public class FloatingObjectReader extends DataReader<FloatingObject> { return transmittingBuoy; } - private void reset(ImportDataContext dataContext) { - // as soon as entity was flush, let's clear internal states - dataContext.setObservedSystemCodes(null); - } - private void addObjectMaterial(String vesselActivityCode, Set<String> objectMaterialUsed, ObjectMaterial objectMaterial, boolean whenArriving, boolean whenLeaving, FloatingObject floatingObject) { if (!whenArriving && !whenLeaving) { throw new IllegalStateException(String.format("Can't have not whenArriving and not whenLeaving from ACTIVITE.C_OPERA: %s", vesselActivityCode)); View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/3774d8273efe98d3f0094a48… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/3774d8273efe98d3f0094a48… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][develop] 3 commits: use proper callback for the dedicated option (we need to reload database to...
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: 1ad00f06 by Tony Chemit at 2024-12-10T16:39:40+01:00 use proper callback for the dedicated option (we need to reload database to recompute all permissions) - - - - - a5305eba by Tony Chemit at 2024-12-10T17:08:44+01:00 fix content title text and icon when db is editable - - - - - 3774d827 by Tony Chemit at 2024-12-10T17:11:33+01:00 Merge branch 'feature/issue_2951' into develop L'option d'édition du référentiel d'une base locale nécessite un rechargement manuel de la source de données - Closes #2951 - - - - - 2 changed files: - client/core/src/main/java/fr/ird/observe/client/main/body/ClientConfigUI.java - client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/referential/ContentReferentialUIHandler.java Changes: ===================================== client/core/src/main/java/fr/ird/observe/client/main/body/ClientConfigUI.java ===================================== @@ -414,7 +414,7 @@ public class ClientConfigUI extends JXTitledPanel implements WithClientUIContext helper.addOption(ClientConfigOption.H2_CAN_MIGRATE).setOptionCallBack("application"); helper.addOption(ClientConfigOption.OBSTUNA_CAN_MIGRATE).setOptionCallBack("application"); helper.addOption(ClientConfigOption.H2_SERVER_PORT).setOptionCallBack("application"); - helper.addOption(ClientConfigOption.H2_CAN_EDIT_REFERENTIAL).setOptionCallBack("ui"); + helper.addOption(ClientConfigOption.H2_CAN_EDIT_REFERENTIAL).setOptionCallBack("db"); helper.addOption(ClientConfigOption.AVDTH_FORCE_IMPORT).setOptionCallBack("ui"); helper.addOption(ClientConfigOption.SHOW_SQL); ===================================== client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/referential/ContentReferentialUIHandler.java ===================================== @@ -207,6 +207,23 @@ public class ContentReferentialUIHandler<D extends ReferentialDto, R extends Ref } }; ChangeMode<U> changeMode = new ChangeMode<>(request, changeModeProducer, null) { + @Override + protected void rebuildTitle(U ui, ContentMode newValue) { + if (Objects.equals(newValue, ContentMode.READ) ) { + ContentReferentialUIModelStates<D, R> states = ui.getModel().getStates(); + boolean editable = states.isEditable(); + String titleSuffix; + if (editable) { + titleSuffix = I18n.t("observe.Common.action.updating"); + } else { + titleSuffix = I18n.t("observe.Common.action.notEditable"); + } + String contentTitle = states.getContentTitle() + " - " + titleSuffix; + ui.setTitle(contentTitle); + return; + } + super.rebuildTitle(ui, newValue); + } protected void rebuildAction(U ui, ContentMode newValue) { boolean editable; @@ -230,7 +247,7 @@ public class ContentReferentialUIHandler<D extends ReferentialDto, R extends Ref editable = states.isEditable(); if (editable) { tip = I18n.n("observe.data.Openable.action.editable.tip"); - icon = UIHelper.getContentActionIcon("locked"); + icon = UIHelper.getContentActionIcon("unlocked"); } else { tip = I18n.n("observe.data.Openable.action.notEditable.tip"); icon = UIHelper.getContentActionIcon("not-editable"); View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/5f4f009403f9958233e68599… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/5f4f009403f9958233e68599… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][develop] 4 commits: Remove tagNumber data-binding (this is already done by the handler)
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: ae91f8e4 by Tony Chemit at 2024-12-10T16:25:47+01:00 Remove tagNumber data-binding (this is already done by the handler) - - - - - 7bd20224 by Tony Chemit at 2024-12-10T16:26:03+01:00 Remove tagNumber data-binding (this is already done by the handler) - - - - - 1c05758d by Tony Chemit at 2024-12-10T16:26:46+01:00 Make number enabled when individual and disabled (with value removed) when grouped - - - - - 5f4f0094 by Tony Chemit at 2024-12-10T16:26:52+01:00 Merge branch 'feature/issue_2950' into develop LL/observations/capture : Champ numéro au virage devrait être désactivé en saisie groupée - Closes #2950 - - - - - 2 changed files: - client/datasource/editor/ll/src/main/java/fr/ird/observe/client/datasource/editor/ll/data/observation/SetCatchUI.jcss - client/datasource/editor/ll/src/main/java/fr/ird/observe/client/datasource/editor/ll/data/observation/SetCatchUIHandler.java Changes: ===================================== client/datasource/editor/ll/src/main/java/fr/ird/observe/client/datasource/editor/ll/data/observation/SetCatchUI.jcss ===================================== @@ -58,10 +58,6 @@ enabled:{!tableModel.isEditable() || tableModel.isCreate()}; } -#tagNumber { - enabled:{tableEditBean.getAcquisitionMode() == 0}; -} - /* ***************************************************************************** */ /* DEPREDATED TAB ************************************************************* */ /* ***************************************************************************** */ ===================================== client/datasource/editor/ll/src/main/java/fr/ird/observe/client/datasource/editor/ll/data/observation/SetCatchUIHandler.java ===================================== @@ -257,6 +257,7 @@ public class SetCatchUIHandler extends GeneratedSetCatchUIHandler { case GROUPED: if (createMode) { editBean.setCount(null); + editBean.setNumber(null); editBean.setTagNumber(null); editBean.setSection(null); editBean.setBasket(null); @@ -286,6 +287,8 @@ public class SetCatchUIHandler extends GeneratedSetCatchUIHandler { ui.getSection().setEnabled(isIndividual); ui.getBasket().setEnabled(isIndividual); ui.getBranchline().setEnabled(isIndividual); + ui.getNumber().setEnabled(isIndividual); + ui.getTagNumber().setEnabled(isIndividual); if (createMode) { // on propage le mode de saisie dans le bean editBean.setAcquisitionMode(newMode.ordinal()); View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/13479925786d8dc245f45b6b… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/13479925786d8dc245f45b6b… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][develop] 4 commits: Rename method ObjectMaterialDto.isCodeValid to...
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: 22ff23ea by Tony Chemit at 2024-12-10T15:57:59+01:00 Rename method ObjectMaterialDto.isCodeValid to ObjectMaterialDto.isCodeCompliantWithParent and improve it - - - - - 981ba480 by Tony Chemit at 2024-12-10T15:58:36+01:00 Rename method ObjectMaterialDto.isCodeValid to ObjectMaterialDto.isCodeCompliantWithParent and improve it - - - - - c8f2b90f by Tony Chemit at 2024-12-10T15:59:18+01:00 Only validate code if material has a parent - - - - - 13479925 by Tony Chemit at 2024-12-10T15:59:31+01:00 Merge branch 'feature/issue_2952' into develop Problème dans la consultation des données de référence Objet flottant matériel - Closes #2952 - - - - - 5 changed files: - core/api/dto/src/main/java/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto.java - core/api/validation/src/main/resources/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-create-error-validation.json - core/api/validation/src/main/resources/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-update-error-validation.json - core/api/validation/src/main/validation/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-create-error-validation.json - core/api/validation/src/main/validation/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-update-error-validation.json Changes: ===================================== core/api/dto/src/main/java/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto.java ===================================== @@ -45,16 +45,28 @@ public class ObjectMaterialDto extends GeneratedObjectMaterialDto { return objectMaterialType != null && ProtectedIdsPs.PS_COMMON_OBJECT_MATERIAL_TYPE_FLOAT.equals(objectMaterialType.getId()); } - public boolean isCodeValid() { + /** + * @return {@code true} if code is compliant with his associated parent code, {@code false} otherwise. + * @see #getParent() + * @see #getCode() + */ + public boolean isCodeCompliantWithParent() { ObjectMaterialReference parent = getParent(); + String code = getCode(); if (parent == null) { + // If no parent, then accept anything here return true; } + if (code == null || code.trim().isEmpty()) { + // If a parent is defined, code can not be null nor empty + return false; + } String parentCode = parent.getCode(); - if (parentCode == null || parentCode.isEmpty()) { + if (parentCode == null || parentCode.trim().isEmpty()) { + // if parent code is null or empty, then accept any code (even if we might only accept code without any «-» inside it) return true; } - String code = getCode(); + // In any other cases, code must starts with «parentCode-» return code.startsWith(parentCode + "-"); } ===================================== core/api/validation/src/main/resources/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-create-error-validation.json ===================================== @@ -16,7 +16,8 @@ "validator": "io.ultreia.java4all.validation.impl.java.validator.FieldExpressionValidator", "comment": "code must be compliant with his parent code", "parameters": { - "expression": "$o.codeValid" + "skip": "$o.parent == null", + "expression": "$o.codeCompliantWithParent" }, "message": "observe.referential.ps.common.ObjectMaterial.validation.bad.parentCode##$o.parent.code" } ===================================== core/api/validation/src/main/resources/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-update-error-validation.json ===================================== @@ -16,7 +16,8 @@ "validator": "io.ultreia.java4all.validation.impl.java.validator.FieldExpressionValidator", "comment": "code must be compliant with his parent code", "parameters": { - "expression": "$o.codeValid" + "skip": "$o.parent == null", + "expression": "$o.codeCompliantWithParent" }, "message": "observe.referential.ps.common.ObjectMaterial.validation.bad.parentCode##$o.parent.code" } ===================================== core/api/validation/src/main/validation/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-create-error-validation.json ===================================== @@ -4,7 +4,8 @@ "validator": "io.ultreia.java4all.validation.impl.java.validator.FieldExpressionValidator", "comment": "code must be compliant with his parent code", "parameters": { - "expression": "$o.codeValid" + "skip" : "$o.parent == null", + "expression": "$o.codeCompliantWithParent" }, "message": "observe.referential.ps.common.ObjectMaterial.validation.bad.parentCode##$o.parent.code" } ===================================== core/api/validation/src/main/validation/fr/ird/observe/dto/referential/ps/common/ObjectMaterialDto-update-error-validation.json ===================================== @@ -4,7 +4,8 @@ "validator": "io.ultreia.java4all.validation.impl.java.validator.FieldExpressionValidator", "comment": "code must be compliant with his parent code", "parameters": { - "expression": "$o.codeValid" + "skip" : "$o.parent == null", + "expression": "$o.codeCompliantWithParent" }, "message": "observe.referential.ps.common.ObjectMaterial.validation.bad.parentCode##$o.parent.code" } View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/4d2d332a0d5e8e195959f23f… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/compare/4d2d332a0d5e8e195959f23f… You're receiving this email because of your account on gitlab.com.

1 0

[Git][ultreiaio/ird-observe][develop] Souci de l'UI configuration sur les options de type liste - Closes #2956
by Tony CHEMIT (＠tchemit) 10 Dec '24

10 Dec '24

Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: 4d2d332a by Tony Chemit at 2024-12-10T13:39:45+01:00 Souci de l'UI configuration sur les options de type liste - Closes #2956 - - - - - 1 changed file: - client/core/src/main/java/fr/ird/observe/client/main/body/ClientConfigUI.java Changes: ===================================== client/core/src/main/java/fr/ird/observe/client/main/body/ClientConfigUI.java ===================================== @@ -123,7 +123,6 @@ public class ClientConfigUI extends JXTitledPanel implements WithClientUIContext public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus, int row, int column) { - String speciesListId = String.valueOf(value); SpeciesListReference speciesList = entityMap.get(speciesListId); return super.getTableCellRendererComponent(table, decorator.decorate(speciesList), isSelected, hasFocus, row, column); @@ -162,13 +161,16 @@ public class ClientConfigUI extends JXTitledPanel implements WithClientUIContext if (value instanceof String) { value = SpeciesListTableCellEditor.this.entityMap.get(String.valueOf(value)); } + if (value==null) { + return; + } component.setSelectedItem((SpeciesListReference) value); } @Override public Object getCellEditorValue() { SpeciesListReference selectedItem = component.getModel().getSelectedItem(); - return selectedItem.getId(); + return selectedItem == null ? null : selectedItem.getId(); } @Override @@ -182,6 +184,10 @@ public class ClientConfigUI extends JXTitledPanel implements WithClientUIContext @Override public boolean stopCellEditing() { + if (component.getModel().getSelectedItem()==null) { + super.cancelCellEditing(); + return true; + } if (component.getConfig().isEditable()) { // Commit edited value. component.getCombobox().actionPerformed(new ActionEvent(SpeciesListTableCellEditor.this, 0, "")); View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/4d2d332a0d5e8e195959f23f9… -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/4d2d332a0d5e8e195959f23f9… You're receiving this email because of your account on gitlab.com.

1 0