This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository wikitty. See http://git.nuiton.org/wikitty.git commit ce0b3e42c7b6aed0c2e4ec04e01cb40baae7d675 Author: Benjamin POUSSIN <poussin@codelutin.com> Date: Sun Aug 2 14:17:26 2015 +0200 fixes bug in containsAll with empty collection (no result expected) --- .../java/org/nuiton/wikitty/storage/WikittySearchEngineInMemory.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/wikitty-api/src/main/java/org/nuiton/wikitty/storage/WikittySearchEngineInMemory.java b/wikitty-api/src/main/java/org/nuiton/wikitty/storage/WikittySearchEngineInMemory.java index 980bb92..daeac42 100644 --- a/wikitty-api/src/main/java/org/nuiton/wikitty/storage/WikittySearchEngineInMemory.java +++ b/wikitty-api/src/main/java/org/nuiton/wikitty/storage/WikittySearchEngineInMemory.java @@ -472,7 +472,10 @@ public class WikittySearchEngineInMemory implements WikittySearchEngine { static private Predicate ContainsAllPredicate = new Predicate() { public boolean check(FieldType type, Collection values, Collection expected) { boolean result = false; - if (values != null) { + // si expected est vide alors rien ne doit matcher + // http://www.nuiton.org/issues/3735 + // Anomalie #3735: containsOne and containsAll with an empty collection returns all objects but no object should have been returned + if (values != null && CollectionUtils.isNotEmpty(expected)) { expected = CollectionUtils.subtract(expected, values); // si lorsqu'on retire tous les elements en commun avec la valeur // du champs il ne reste plus rien, c'est que le containsAll est -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.